Repository navigation
Use messagesKey instead of string - #1364
Merged
austinwright merged 1 commit intoJun 1, 2020
Merged
austinwright merged 1 commit into
austinwright merged 1 commit into
Conversation
messagesKey was initialized but not used
austinwright
changed the base branch from
development
to
Use-messagesKey-instead-of-string
June 1, 2020 17:37
Member
|
Thank you for contributing to MessageKit! I've invited you to join the MessageKit GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines and join the MessageKit Slack channel. Feel free to reach out if you have any questions! 😃 |
austinwright
added a commit
that referenced
this pull request
Jun 1, 2020
Patrick-Kladek
pushed a commit
to medbee/MessageKit
that referenced
this pull request
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
messagesKey was initialized but not used
Does this close any currently open issues?
no
Any relevant logs, error output, etc?
Any other comments?
…
Where has this been tested?
Devices/Simulators:
all
iOS Version: …
all
Swift Version: …
all
MessageKit Version: …
all