Skip to content

Use messagesKey instead of string - #1364

Merged
austinwright merged 1 commit into
MessageKit:Use-messagesKey-instead-of-stringfrom
musa-almatri:patch-1
Jun 1, 2020
Merged

austinwright merged 1 commit into
MessageKit:Use-messagesKey-instead-of-stringfrom
musa-almatri:patch-1

Conversation

@musa-almatri

@musa-almatri musa-almatri commented Jun 1, 2020 •

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

messagesKey was initialized but not used

Does this close any currently open issues?

no

Any relevant logs, error output, etc?

Any other comments?

…

Where has this been tested?

Devices/Simulators:
all
iOS Version: …
all
Swift Version: …
all
MessageKit Version: …
all

messagesKey was initialized but not used

@martinpucik martinpucik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@austinwright
austinwright changed the base branch from master to development June 1, 2020 16:40
@austinwright
austinwright changed the base branch from development to Use-messagesKey-instead-of-string June 1, 2020 17:37

@austinwright austinwright left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@austinwright
austinwright merged commit 87446a2 into MessageKit:Use-messagesKey-instead-of-string Jun 1, 2020
@SD10

SD10 commented Jun 1, 2020

Copy link
Copy Markdown
Member

Thank you for contributing to MessageKit! I've invited you to join the MessageKit GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines and join the MessageKit Slack channel. Feel free to reach out if you have any questions! 😃

austinwright added a commit that referenced this pull request Jun 1, 2020
Patrick-Kladek pushed a commit to medbee/MessageKit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants