Swift Package Manager support without RxSwift dependency by martinpucik · Pull Request #1341 · MessageKit/MessageKit

martinpucik · 2020-04-29T08:43:09Z

What does this implement/fix? Explain your changes.

Added support for Swift Package Manager with updated package description
Using InpuBarAccessoryView dependency without linking RxSwift
👻

Does this close any currently open issues?

Closes Swift Package Manager support #1225

Any relevant logs, error output, etc?

N/A

Any other comments?

N/A

Where has this been tested?

Devices/Simulators: N/A

iOS Version: iOS 11 - 13

Swift Version: 5.2

MessageKit Version: 3

Using InputAccessoryView dependency without Rx

Add missing imports

martinpucik · 2020-04-29T08:44:28Z

+    dependencies: [
+        // Dependencies declare other packages that this package depends on.
+        // .package(url: /* package url */, from: "1.0.0"),
+        .package(url: "https://github.com/classdojo/InputBarAccessoryView", .branch("dropRxSPM"))


Linking to fork without RxSwift dependency while waiting on merging this to InputBarAccessoryView

Kaspik

needs readme update to inform users about CocoaPods able to have RxSwift extensions where SPM doesn't have this option
needs changelog update
let's wait about two/three days and see if IBAV will be merged

kinoroy

We can't merge this until SE-0271 is implemented in Swift 5.3 which will allow SPM to support bundling assets.
No solid timeline on 5.3 but it was branched from master last week so will probably have a bake-in period of a few months for them to iron it out.

I recreated the example app repo here using this branch as the MessageKit dependency (through SPM) and it crashes with

Fatal error: MessageKit: Could not create path to the assets bundle.

Kaspik · 2020-04-29T19:02:42Z

@kinoroy I don't see AppDelegate.swift in your project after downloading it.

Also, we use it through SPM on our project whole day today without any issue. I'll check your project for sure, but I believe it should work as long as the assets are included only in the framework - you just can't load them in your main project manually.

EDIT: Also sounds are missing.

kinoroy · 2020-04-29T19:07:59Z

@Kaspik My bad, they weren't added into the repo properly but they were there locally when I tested it. Should be fixed now

kinoroy · 2020-04-29T19:09:27Z

@Kaspik Do you use the typing indicator in your project?

Kaspik · 2020-04-29T19:22:24Z

Ohhh, yeah, tested your Example app it does work for Advanced example etc (because of custom cell layout), but it doesn't work for default / basic one.

Sad story. It's still helpful for users with non-default styling, but yeah we will need to wait for XCode 12.

martinpucik · 2020-04-30T07:43:58Z

Yes, unfortunately there is still no support for assets in SPM package :(

But, as .custom MessageStyle is working fine and someone (like me 😹) may find it useful, I'd like to keep this PR and branch open.

We could then point any questions about SPM to this conversation

codecov · 2020-06-10T13:12:58Z

Codecov Report

Merging #1341 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development    #1341   +/-   ##
============================================
  Coverage        64.75%   64.75%           
============================================
  Files               68       68           
  Lines             3305     3305           
============================================
  Hits              2140     2140           
  Misses            1165     1165

Impacted Files	Coverage Δ
.../Controllers/MessagesViewController+Keyboard.swift	`19.04% <ø> (ø)`
...rces/Controllers/MessagesViewController+Menu.swift	`10.52% <ø> (ø)`
Sources/Extensions/CGRect+Extensions.swift	`100.00% <ø> (ø)`
...ces/Extensions/NSAttributedString+Extensions.swift	`100.00% <ø> (ø)`
Sources/Extensions/UIColor+Extensions.swift	`58.18% <ø> (ø)`
Sources/Extensions/UIEdgeInsets+Extensions.swift	`100.00% <ø> (ø)`
Sources/Layout/AudioMessageSizeCalculator.swift	`63.63% <ø> (ø)`
Sources/Layout/ContactMessageSizeCalculator.swift	`0.00% <ø> (ø)`
Sources/Layout/LocationMessageSizeCalculator.swift	`63.63% <ø> (ø)`
Sources/Layout/MediaMessageSizeCalculator.swift	`73.33% <ø> (ø)`
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2572e3c...4761b3d. Read the comment docs.

Added Package description with Assets support for Swift 5.3

Remove .swiftpm temp files

Ignore .swiftpm temp files

Remove Package.resolved

Ignore Package.resolved

Assets in framework project

Fix tests

Try Bundle.module to get MessageKit bundle

SPM condition in bundle

Remove previous Swift 5.2 version Package.swift

Update Readme with SPM installation

martinpucik · 2020-06-30T15:15:08Z

@kinoroy @Kaspik I added support Swift Package with assets in Swift 5.3/Xcode 12.
I'll keep a branch for Swift 5.2 SPM support without assets up spm-5_2

…1341) * feat: SPM support Using InputAccessoryView dependency without Rx * feat: SPM support Add missing imports * feat: Swift Package Manager support Added Package description with Assets support for Swift 5.3 * feat: Swift Package Manager support Remove .swiftpm temp files * feat: Swift Package Manager support Ignore .swiftpm temp files * feat: Swift Package Manager support Remove Package.resolved * feat: Swift Package Manager support Ignore Package.resolved * feat: Swift Package Manager support Assets in framework project * feat: Swift Package Manager support Fix tests * feat: Swift Package Manager support Fix tests * feat: Swift Package Manager support Fix tests * feat: Swift Package Manager support Try Bundle.module to get MessageKit bundle * feat: Swift Package Manager support SPM condition in bundle * feat: Swift Package Manager support Remove previous Swift 5.2 version Package.swift * feat: Swift Package Manager support Update Readme with SPM installation

martinpucik added 2 commits April 28, 2020 16:58

feat: SPM support

ada6572

Using InputAccessoryView dependency without Rx

feat: SPM support

fcce3b3

Add missing imports

martinpucik commented Apr 29, 2020

View reviewed changes

martinpucik added the infrastructure label Apr 29, 2020

Kaspik reviewed Apr 29, 2020

View reviewed changes

Kaspik mentioned this pull request Apr 29, 2020

Support Swift Package Manager #1239

Closed

kinoroy reviewed Apr 29, 2020

View reviewed changes

kinoroy added the blocked blocked on an external factor (other PR, external library, iOS/Swift version, etc) label May 14, 2020

Merge branch 'development' into spm

118962f

yspreen mentioned this pull request Jun 15, 2020

SPM Support and Resources hyperoslo/Lightbox#250

Closed

martinpucik and others added 14 commits June 24, 2020 08:24

Merge branch 'development' into spm

b368ac4

Merge branch 'development' into spm

a42e548

feat: Swift Package Manager support

f9d1dec

Added Package description with Assets support for Swift 5.3

feat: Swift Package Manager support

376d11d

Remove .swiftpm temp files

feat: Swift Package Manager support

6aacb3f

Ignore .swiftpm temp files

feat: Swift Package Manager support

e3a286e

Remove Package.resolved

feat: Swift Package Manager support

9cb656d

Ignore Package.resolved

feat: Swift Package Manager support

a52a7c6

Assets in framework project

feat: Swift Package Manager support

161fd43

Fix tests

feat: Swift Package Manager support

95e3bb9

Fix tests

feat: Swift Package Manager support

325b252

Fix tests

feat: Swift Package Manager support

2cfebfb

Try Bundle.module to get MessageKit bundle

feat: Swift Package Manager support

9165231

SPM condition in bundle

feat: Swift Package Manager support

89d2ccf

Remove previous Swift 5.2 version Package.swift

feat: Swift Package Manager support

4761b3d

Update Readme with SPM installation

Kaspik approved these changes Jun 30, 2020

View reviewed changes

martinpucik merged commit 81395b6 into development Jun 30, 2020

martinpucik deleted the spm branch June 30, 2020 15:24

kinoroy mentioned this pull request Jun 30, 2020

Images instantiated with contentsOf: leak their path #1388

Closed

Kaspik mentioned this pull request Aug 5, 2020

Why is there no support for Swift Package Manager #1425

Closed

Navigation Menu

Repository navigation

Swift Package Manager support without RxSwift dependency - #1341

Swift Package Manager support without RxSwift dependency#1341
martinpucik merged 18 commits into
developmentfrom
spm

martinpucik commented Apr 29, 2020 •

edited

Loading

Uh oh!

martinpucik Apr 29, 2020

Uh oh!

Kaspik left a comment

Uh oh!

kinoroy left a comment

Uh oh!

Kaspik commented Apr 29, 2020 •

edited

Loading

Uh oh!

kinoroy commented Apr 29, 2020

Uh oh!

kinoroy commented Apr 29, 2020

Uh oh!

Kaspik commented Apr 29, 2020

Uh oh!

martinpucik commented Apr 30, 2020

Uh oh!

codecov Bot commented Jun 10, 2020 •

edited

Loading

Uh oh!

martinpucik commented Jun 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

martinpucik commented Apr 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this implement/fix? Explain your changes.

Does this close any currently open issues?

Any relevant logs, error output, etc?

Any other comments?

Where has this been tested?

Uh oh!

martinpucik Apr 29, 2020

Choose a reason for hiding this comment

Uh oh!

Kaspik left a comment

Choose a reason for hiding this comment

Uh oh!

kinoroy left a comment

Choose a reason for hiding this comment

Uh oh!

Kaspik commented Apr 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kinoroy commented Apr 29, 2020

Uh oh!

kinoroy commented Apr 29, 2020

Uh oh!

Kaspik commented Apr 29, 2020

Uh oh!

martinpucik commented Apr 30, 2020

Uh oh!

codecov Bot commented Jun 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

martinpucik commented Jun 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

martinpucik commented Apr 29, 2020 •

edited

Loading

Kaspik commented Apr 29, 2020 •

edited

Loading

codecov Bot commented Jun 10, 2020 •

edited

Loading