Repository navigation
Conversation
|
@zhongwuzw @SD10 @nathantannar4 could you take a look at PRs? Or maybe add a few members to keep this project alive? |
|
@hyouuu Hey, sorry we don't have much time on it, would u want to collaborate to help us? or any members you can recommend? |
|
Yes I would love to at least do PR reviews so the community can help move it forward :) |
|
Didn't pay close attention to contributions but you could look into PR submission etc to see who would be the best candidates |
I added you and @moldovaniosif write permission of master, please help us to move on. :) |
|
Nice thanks! |
|
@zhongwuzw would you be able to grant access to circle so I can re-run test for #1189 |
| targets: ["MessageKit"]) | ||
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/Nixon506E/InputBarAccessoryView.git", from: "4.2.1") |
There was a problem hiding this comment.
Saw your branch is 2 commits ahead - assuming you'll keep it updated :)
There was a problem hiding this comment.
Please open PR to the original repo - this can't be merged I believe.
| } | ||
| }, | ||
| { | ||
| "package": "RxSwift", |
There was a problem hiding this comment.
Do we actually use RxSwift in MessageKit?
There was a problem hiding this comment.
Soo, that's something we should talk about and take action asap - there is RxSwift dependency for InputBarAccessory but I believe it's wrong.
There was a problem hiding this comment.
RxSwift should be taken away and aded as an optional dependency / extension.
| targets: ["MessageKit"]) | ||
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/Nixon506E/InputBarAccessoryView.git", from: "4.2.1") |
There was a problem hiding this comment.
Please open PR to the original repo - this can't be merged I believe.
| } | ||
| }, | ||
| { | ||
| "package": "RxSwift", |
There was a problem hiding this comment.
RxSwift should be taken away and aded as an optional dependency / extension.
|
Also please point to the |
|
@austinwright , Can we get this PR merged? Really need this feature. |
|
We can't yet, it's not even up-to-date, as well as we should split this and RxSwift extension so people with SPM don't hve Rx included. |
|
@Kaspik, Can I help to speed up the process? |
|
@xcodefriend It would be nice to find a way how to have RxMessageKit split out of main project with main project as a dependency, so we can have separate Package file for that and separate for main project without RxExtensions completely. What do you think? |
|
Closing in favor of #1341. |
No description provided.