Skip to content

Use ASCII control-range regex instead of Unicode property escape for password input #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melvincarvalho merged 1 commit into from
May 24, 2026
Merged

Use ASCII control-range regex instead of Unicode property escape for password input #525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,12 +1067,15 @@ export function createServer(options = {}) {
password = password.slice(0, -1);
return;
}
// Only accept printable input — \P{C} excludes control codes,
// so escape sequences from arrow keys, function keys, etc. don't
// sneak invisible bytes into the password buffer.
// Only accept printable input — reject C0/C1 control codes, so
// escape sequences from arrow keys, function keys, etc. don't
// sneak invisible bytes into the password buffer. Uses an explicit
// ASCII/C1 control range rather than the \p{C} Unicode property
// escape, which requires a full-ICU build and throws at parse time
// on no-ICU runtimes (e.g. nodejs-mobile). See #520.
if (!key.ctrl && !key.meta &&
typeof str === 'string' && str.length > 0 &&
/^\P{C}+$/u.test(str)) {
/^[^\u0000-\u001f\u007f-\u009f]+$/.test(str)) {
password += str;
}
};
Expand Down