Use ASCII control-range regex instead of Unicode property escape for password input#525
Merged
Merged
Conversation
/^\P{C}+$/u throws "Invalid property name" at parse time on Node builds
without full ICU (e.g. nodejs-mobile), so the module fails to load and
the server can't boot there. Replace with an explicit C0/C1 control
exclusion, which needs no ICU and matches the actual intent (keep
control/escape bytes out of the interactive password buffer).
Closes #520
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/server.jsvalidated interactive password input with a Unicode property-escape regex (the\P{C}form with theuflag).SyntaxError: Invalid regular expression: Invalid property nameat parse time on Node builds without full ICU (e.g. nodejs-mobile), so the module fails to import and the server can't boot there.\u-escapes — nouflag, no ICU. Preserves the intent: keep control/escape bytes from arrow/function keys out of the password buffer.Closes #520. Surfaced running JSS on Android (nodejs-mobile); see #522.
Notes
Test plan
createServer()imports on a no-ICU Node build (no parse-time throw).