Merge pull request microsoft#5043 from Microsoft/findRefsOnVarInExtends

DanielRosenwasser · DanielRosenwasser · commit acef223f9533 · 2015-10-01T12:36:12.000-07:00
Correctly recognize value symbol presence of expressions in extends clauses
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -14224,7 +14224,21 @@ namespace ts {
             }
 
             if (isHeritageClauseElementIdentifier(<EntityName>entityName)) {
-                let meaning = entityName.parent.kind === SyntaxKind.ExpressionWithTypeArguments ? SymbolFlags.Type : SymbolFlags.Namespace;
+                let meaning = SymbolFlags.None;
+
+                // In an interface or class, we're definitely interested in a type.
+                if (entityName.parent.kind === SyntaxKind.ExpressionWithTypeArguments) {
+                    meaning = SymbolFlags.Type;
+
+                    // In a class 'extends' clause we are also looking for a value.
+                    if (isExpressionWithTypeArgumentsInClassExtendsClause(entityName.parent)) {
+                        meaning |= SymbolFlags.Value;
+                    }
+                }
+                else {
+                    meaning = SymbolFlags.Namespace;
+                }
+
                 meaning |= SymbolFlags.Alias;
                 return resolveEntityName(<EntityName>entityName, meaning);
             }
diff --git a/tests/baselines/reference/extendClassExpressionFromModule.symbols b/tests/baselines/reference/extendClassExpressionFromModule.symbols
@@ -8,6 +8,7 @@ var x = foo1;
 
 class y extends x {}
 >y : Symbol(y, Decl(foo2.ts, 1, 13))
+>x : Symbol(x, Decl(foo2.ts, 1, 3))
 
 === tests/cases/conformance/classes/classExpressions/foo1.ts ===
 class x{}
diff --git a/tests/baselines/reference/extendNonClassSymbol1.symbols b/tests/baselines/reference/extendNonClassSymbol1.symbols
@@ -9,4 +9,5 @@ var x = A;
 
 class C extends x { } // error, could not find symbol xs
 >C : Symbol(C, Decl(extendNonClassSymbol1.ts, 1, 10))
+>x : Symbol(x, Decl(extendNonClassSymbol1.ts, 1, 3))
 
diff --git a/tests/cases/fourslash/findAllRefsForVariableInExtendsClause01.ts b/tests/cases/fourslash/findAllRefsForVariableInExtendsClause01.ts
@@ -0,0 +1,15 @@
+﻿/// <reference path="fourslash.ts"/>
+
+
+////var [|Base|] = class { };
+////class C extends [|Base|] { }
+
+let ranges = test.ranges();
+for (let range of ranges) {
+    goTo.position(range.start);
+
+    verify.referencesCountIs(ranges.length);
+    for (let expectedReference of ranges) {
+        verify.referencesAtPositionContains(expectedReference);
+    }
+}
diff --git a/tests/cases/fourslash/findAllRefsForVariableInExtendsClause02.ts b/tests/cases/fourslash/findAllRefsForVariableInExtendsClause02.ts
@@ -0,0 +1,17 @@
+﻿/// <reference path="fourslash.ts"/>
+
+////interface [|Base|] { }
+////namespace n {
+////    var Base = class { };
+////    interface I extends [|Base|] { }
+////}
+
+let ranges = test.ranges();
+for (let range of ranges) {
+    goTo.position(range.start);
+
+    verify.referencesCountIs(ranges.length);
+    for (let expectedReference of ranges) {
+        verify.referencesAtPositionContains(expectedReference);
+    }
+}
diff --git a/tests/cases/fourslash/findAllRefsForVariableInImplementsClause01.ts b/tests/cases/fourslash/findAllRefsForVariableInImplementsClause01.ts
@@ -0,0 +1,10 @@
+﻿/// <reference path="fourslash.ts"/>
+
+
+////var Base = class { };
+////class C extends Base implements [|Base|] { }
+
+let ranges = test.ranges();
+for (let range of ranges) {
+    verify.referencesCountIs(0);
+}

Original file line number	Diff line number	Diff line change
`@@ -9,4 +9,5 @@ var x = A;`
`9`	`9`
`10`	`10`	`class C extends x { } // error, could not find symbol xs`
`11`	`11`	`>C : Symbol(C, Decl(extendNonClassSymbol1.ts, 1, 10))`
	`12`	`+>x : Symbol(x, Decl(extendNonClassSymbol1.ts, 1, 3))`
`12`	`13`