Correctly recognize value symbol presence of expressions in extends clauses#5043
Merged
Conversation
Member
There was a problem hiding this comment.
You should only add the Value flag if this is a heritage clause of a class expression (see other comment)
35f2416 to
e9dc1fb
Compare
Member
Author
|
Addressed your feedback @RyanCavanaugh |
Contributor
|
👍 |
1 similar comment
Member
|
👍 |
DanielRosenwasser
added a commit
that referenced
this pull request
Oct 1, 2015
Correctly recognize value symbol presence of expressions in extends clauses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5028.
Basically we were failing to account for the fact that expressions in
extendsclauses are expressions...Edit: But only in class extends clauses.