Skip to content

feat: Add support for REFRESH MATERIALIZED VIEW #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manticore-projects merged 12 commits into from
Dec 11, 2023
Merged

feat: Add support for REFRESH MATERIALIZED VIEW #1911

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
396a39b
Support REFRESH MATERIALIZED VIEW
jxnu-liguobin Dec 7, 2023
de6340d
Fix
jxnu-liguobin Dec 7, 2023
24d01e1
Rename
jxnu-liguobin Dec 7, 2023
e1c9119
Rename
jxnu-liguobin Dec 7, 2023
2f8f4e9
fmt
jxnu-liguobin Dec 7, 2023
54b5dec
fmt
jxnu-liguobin Dec 8, 2023
5cdc502
Add test
jxnu-liguobin Dec 8, 2023
df2136e
Fix jjt
jxnu-liguobin Dec 8, 2023
17dda87
Fix jjt
jxnu-liguobin Dec 8, 2023
f78139b
Fix jjt
jxnu-liguobin Dec 8, 2023
7fca4b3
typo
jxnu-liguobin Dec 8, 2023
c5ba0f1
rebase master
jxnu-liguobin Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename
  • Loading branch information
@jxnu-liguobin
jxnu-liguobin committed Dec 11, 2023
commit 24d01e1ae47abeb53b32cbd69065ef3bea5d4200
16 changes: 8 additions & 8 deletions src/main/java/net/sf/jsqlparser/statement/refreshView/RefreshMaterializedViewStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@
public class RefreshMaterializedViewStatement implements Statement {

private String tableName;
private RefreshType refreshType = RefreshType.DEFAULT;
private RefreshMode refreshMode = RefreshMode.DEFAULT;
private boolean concurrently;

public RefreshMaterializedViewStatement() {
}

public RefreshMaterializedViewStatement(RefreshType refreshType) {
this.refreshType = refreshType;
public RefreshMaterializedViewStatement(RefreshMode refreshMode) {
this.refreshMode = refreshMode;
}

public RefreshMaterializedViewStatement(String tableName) {
Expand All @@ -45,12 +45,12 @@ public void setTableName(String tableName) {
this.tableName = tableName;
}

public RefreshType getRefreshType() {
return refreshType;
public RefreshMode getRefreshMode() {
return refreshMode;
}

public void setRefreshType(RefreshType refreshType) {
this.refreshType = refreshType;
public void setRefreshMode(RefreshMode refreshMode) {
this.refreshMode = refreshMode;
}

public boolean isConcurrently() {
Expand All @@ -66,7 +66,7 @@ public void setConcurrently(boolean concurrently) {
public String toString() {
StringBuilder builder = new StringBuilder();
builder.append("REFRESH MATERIALIZED VIEW ");
switch (this.refreshType) {
switch (this.refreshMode) {
case WITH_DATA:
if (concurrently) {
builder.append("CONCURRENTLY ");
Expand Down
6 changes: 3 additions & 3 deletions ...er/statement/refreshView/RefreshType.java → ...er/statement/refreshView/RefreshMode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
*/
package net.sf.jsqlparser.statement.refreshView;

public enum RefreshType {
public enum RefreshMode {

DEFAULT, WITH_DATA, WITH_NO_DATA;

public static RefreshType from(String type) {
return Enum.valueOf(RefreshType.class, type.toUpperCase());
public static RefreshMode from(String type) {
return Enum.valueOf(RefreshMode.class, type.toUpperCase());
}
}
2 changes: 1 addition & 1 deletion src/main/java/net/sf/jsqlparser/util/deparser/RefreshMaterializedViewStatementDeParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public RefreshMaterializedViewStatementDeParser(StringBuilder buffer) {
@Override
public void deParse(RefreshMaterializedViewStatement view) {
buffer.append("REFRESH MATERIALIZED VIEW ");
switch (view.getRefreshType()){
switch (view.getRefreshMode()){
case WITH_DATA:
if (view.isConcurrently()) {
buffer.append("CONCURRENTLY ");
Expand Down
12 changes: 6 additions & 6 deletions ...et/sf/jsqlparser/util/validation/validator/RefreshMaterializedViewStatementValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*/
package net.sf.jsqlparser.util.validation.validator;

import net.sf.jsqlparser.statement.refreshView.RefreshType;
import net.sf.jsqlparser.statement.refreshView.RefreshMode;
import net.sf.jsqlparser.util.validation.ValidationCapability;
import net.sf.jsqlparser.parser.feature.Feature;
import net.sf.jsqlparser.statement.refreshView.RefreshMaterializedViewStatement;
Expand All @@ -26,14 +26,14 @@ public void validate(RefreshMaterializedViewStatement viewStatement) {
validateFeatureAndName(Feature.refreshMaterializedView, NamedObject.table, viewStatement.getTableName());
for (ValidationCapability c : getCapabilities()) {
// default
validateFeature(c, viewStatement.getRefreshType().compareTo(RefreshType.DEFAULT) == 0, Feature.refreshMaterializedView);
validateFeature(c, viewStatement.getRefreshMode().compareTo(RefreshMode.DEFAULT) == 0, Feature.refreshMaterializedView);
// specify WITH DATA
validateFeature(c, viewStatement.getRefreshType().compareTo(RefreshType.WITH_DATA) == 0, Feature.refreshMaterializedWithDataView);
validateFeature(c, viewStatement.getRefreshMode().compareTo(RefreshMode.WITH_DATA) == 0, Feature.refreshMaterializedWithDataView);
// specify WITH DATA and CONCURRENTLY
validateOptionalFeature(c, viewStatement.getRefreshType().compareTo(RefreshType.WITH_DATA) == 0 && viewStatement.isConcurrently(), Feature.refreshMaterializedWithDataView);
validateOptionalFeature(c, viewStatement.getRefreshType().compareTo(RefreshType.WITH_DATA) == 0 && viewStatement.isConcurrently(), Feature.refreshMaterializedConcurrentlyView);
validateOptionalFeature(c, viewStatement.getRefreshMode().compareTo(RefreshMode.WITH_DATA) == 0 && viewStatement.isConcurrently(), Feature.refreshMaterializedWithDataView);
validateOptionalFeature(c, viewStatement.getRefreshMode().compareTo(RefreshMode.WITH_DATA) == 0 && viewStatement.isConcurrently(), Feature.refreshMaterializedConcurrentlyView);
// specify WITH NO DATA
validateOptionalFeature(c, viewStatement.getRefreshType().compareTo(RefreshType.WITH_NO_DATA) == 0 && !viewStatement.isConcurrently(), Feature.refreshMaterializedWithNoDataView);
validateOptionalFeature(c, viewStatement.getRefreshMode().compareTo(RefreshMode.WITH_NO_DATA) == 0 && !viewStatement.isConcurrently(), Feature.refreshMaterializedWithNoDataView);
}
}
}
1 change: 0 additions & 1 deletion src/test/java/net/sf/jsqlparser/statement/builder/ReflectionModelTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import net.sf.jsqlparser.schema.Sequence.ParameterType;
import net.sf.jsqlparser.statement.ExplainStatement.OptionType;
import net.sf.jsqlparser.statement.create.table.ColDataType;
import net.sf.jsqlparser.statement.refreshView.RefreshType;
import net.sf.jsqlparser.statement.select.ParenthesedSelect;
import net.sf.jsqlparser.statement.update.UpdateSet;
import net.sf.jsqlparser.util.ReflectionTestUtils;
Expand Down