Skip to content

feat: Add support for REFRESH MATERIALIZED VIEW #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manticore-projects merged 12 commits into from
Dec 11, 2023
Merged

feat: Add support for REFRESH MATERIALIZED VIEW #1911

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
396a39b
Support REFRESH MATERIALIZED VIEW
jxnu-liguobin Dec 7, 2023
de6340d
Fix
jxnu-liguobin Dec 7, 2023
24d01e1
Rename
jxnu-liguobin Dec 7, 2023
e1c9119
Rename
jxnu-liguobin Dec 7, 2023
2f8f4e9
fmt
jxnu-liguobin Dec 7, 2023
54b5dec
fmt
jxnu-liguobin Dec 8, 2023
5cdc502
Add test
jxnu-liguobin Dec 8, 2023
df2136e
Fix jjt
jxnu-liguobin Dec 8, 2023
17dda87
Fix jjt
jxnu-liguobin Dec 8, 2023
f78139b
Fix jjt
jxnu-liguobin Dec 8, 2023
7fca4b3
typo
jxnu-liguobin Dec 8, 2023
c5ba0f1
rebase master
jxnu-liguobin Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix jjt
  • Loading branch information
@jxnu-liguobin
jxnu-liguobin committed Dec 11, 2023
commit 17dda878d77c78bad7d2d4eab03f4906775da111
14 changes: 10 additions & 4 deletions src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,13 +1224,14 @@ ShowIndexStatement ShowIndex(): {
}
}

RefreshMaterializedViewStatement RefreshMaterializedView(): {
Statement RefreshMaterializedView(): {
Table view = null;
boolean concurrently = false;
RefreshMode refreshMode = RefreshMode.DEFAULT;
List<String> captureRest;
}
{
<K_REFRESH> <K_MATERIALIZED> <K_VIEW>
<K_REFRESH> <K_MATERIALIZED> <K_VIEW>
[ LOOKAHEAD(2) <K_CONCURRENTLY> { concurrently = true; } ]
view = Table()
[
Expand All @@ -1239,9 +1240,14 @@ RefreshMaterializedViewStatement RefreshMaterializedView(): {
<K_NO> { refreshMode = RefreshMode.WITH_NO_DATA; }
]
<K_DATA>
]
]
captureRest = captureRest()
{
return new RefreshMaterializedViewStatement(view, concurrently, refreshMode);
if (concurrently && refreshMode == RefreshMode.WITH_NO_DATA) {
return new UnsupportedStatement("REFRESH", captureRest);
} else {
return new RefreshMaterializedViewStatement(view, concurrently, refreshMode);
}
}
}
// https://dev.mysql.com/doc/refman/8.0/en/show-tables.html
Expand Down
13 changes: 10 additions & 3 deletions src/test/java/net/sf/jsqlparser/statement/UnsupportedStatementTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
*/
package net.sf.jsqlparser.statement;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

import net.sf.jsqlparser.JSQLParserException;
import net.sf.jsqlparser.parser.CCJSqlParserUtil;
import net.sf.jsqlparser.statement.select.Select;
Expand All @@ -17,9 +20,6 @@
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.function.Executable;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

public class UnsupportedStatementTest {
@Test
public void testSingleUnsupportedStatement() throws JSQLParserException {
Expand Down Expand Up @@ -88,6 +88,13 @@ void testAlter() throws JSQLParserException {
assertTrue(statement instanceof UnsupportedStatement);
}

@Test
void testRefresh() throws JSQLParserException {
String sqlStr = "REFRESH MATERIALIZED VIEW CONCURRENTLY my_view WITH NO DATA";
Statements statement = CCJSqlParserUtil.parseStatements(sqlStr);
assertTrue(statement.get(0) instanceof UnsupportedStatement);
}

@Test
void testCreate() throws JSQLParserException {
String sqlStr =
Expand Down
4 changes: 4 additions & 0 deletions src/test/java/net/sf/jsqlparser/util/TablesNamesFinderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,5 +516,9 @@ void testRefreshMaterializedView() throws JSQLParserException {
String sqlStr5 = "REFRESH MATERIALIZED VIEW my_view WITH NO DATA";
Set<String> tableNames5 = TablesNamesFinder.findTables(sqlStr5);
assertThat(tableNames5).containsExactlyInAnyOrder("my_view");

String sqlStr6 = "REFRESH MATERIALIZED VIEW CONCURRENTLY my_view WITH NO DATA";
Set<String> tableNames6 = TablesNamesFinder.findTables(sqlStr6);
assertThat(tableNames6).isEmpty();
}
}