Skip to content

Implement PyMap.get with the optional default. #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasmith-hs merged 2 commits into from
Mar 14, 2025
Merged

Implement PyMap.get with the optional default. #1233

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db55adc
Implement PyMap.get with the optional default.
ccutrer Feb 5, 2025
9c60bf5
proxy to existing method
ccutrer Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Implement PyMap.get with the optional default.
  • Loading branch information
@ccutrer
ccutrer committed Feb 5, 2025
commit db55adc791c238761f574c1f41503575b671a2fc
7 changes: 7 additions & 0 deletions src/main/java/com/hubspot/jinjava/objects/collections/PyMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ protected Map<String, Object> delegate() {
return map;
}

public Object get(String key, Object defaultValue) {
if (!map.containsKey(key)) {
return defaultValue;
}
return map.get(key);
Comment thread
ccutrer marked this conversation as resolved.
Outdated
}

@Override
public Object put(String s, Object o) {
if (o == this) {
Expand Down
12 changes: 12 additions & 0 deletions src/test/java/com/hubspot/jinjava/objects/collections/PyMapTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,18 @@ public void itGetsKeysWithVariableName() {
.isEqualTo("value1");
}

@Test
public void itSupportsGetWithOptionalDefault() {
assertThat(
jinjava.render(
"{% set test = {\"key1\": \"value1\"} %}" +
"{{ test.get(\"key2\", \"default\") }}",
Collections.emptyMap()
)
)
.isEqualTo("default");
}

@Test
public void itFallsBackUnknownVariableNameToString() {
assertThat(
Expand Down