Skip to content

Implement PyMap.get with the optional default. #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasmith-hs merged 2 commits into from
Mar 14, 2025
+16 −0
Merged

Implement PyMap.get with the optional default. #1233

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db55adc
Implement PyMap.get with the optional default.
ccutrer Feb 5, 2025
9c60bf5
proxy to existing method
ccutrer Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
proxy to existing method 
Co-authored-by: Jack Smith <72623970+jasmith-hs@users.noreply.github.com>
  • Loading branch information
@ccutrer @jasmith-hs
ccutrer and jasmith-hs authored Mar 14, 2025
commit 9c60bf5114a0e80492b3b2c44fa8fe39fa44dc1c
5 changes: 1 addition & 4 deletions src/main/java/com/hubspot/jinjava/objects/collections/PyMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@ protected Map<String, Object> delegate() {
}

public Object get(String key, Object defaultValue) {
if (!map.containsKey(key)) {
return defaultValue;
}
return map.get(key);
return getOrDefault(key, defaultValue);
}

@Override
Expand Down