Skip to content

fixit: Add type-hints to Python sample at documentai/snippets#9991

Merged
engelke merged 5 commits into
mainfrom
strzelczyk/fixit/280879719
May 18, 2023
Merged

fixit: Add type-hints to Python sample at documentai/snippets#9991
engelke merged 5 commits into
mainfrom
strzelczyk/fixit/280879719

Conversation

@m-strzelczyk
Copy link
Copy Markdown
Contributor

Description

Fixes b/280879719

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: documentai Issues related to the Document AI API. labels May 17, 2023
@m-strzelczyk m-strzelczyk marked this pull request as ready for review May 18, 2023 12:13
@m-strzelczyk m-strzelczyk requested review from a team as code owners May 18, 2023 12:13
@engelke engelke self-assigned this May 18, 2023
Copy link
Copy Markdown
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit ecdec5f into main May 18, 2023
@engelke engelke deleted the strzelczyk/fixit/280879719 branch May 18, 2023 17:41
holtskinner added a commit that referenced this pull request May 19, 2023
holtskinner added a commit that referenced this pull request Jun 15, 2023
- Consolidated process/batch process samples with processor versions
- Update Quickstart to include Processor Creation
- Consolidate Handle Response Samples into a single file to reduce code duplication
  - ~Not sure if I did the region tags completely correct, is there a way to test?~
  - Update: Tested using Devsite staging and it looks correct
- Moved Operations Tests into a single file and removed exception handling in sample
- Add type updates from fixit #9991
gcf-merge-on-green Bot pushed a commit that referenced this pull request Jun 21, 2023
- Consolidated process/batch process samples with processor versions
- Update Quickstart to include Processor Creation
- Consolidate Handle Response Samples into a single file to reduce code duplication
  - ~Not sure if I did the region tags completely correct, is there a way to test?~
  - Update: Tested using Devsite staging and it looks correct
- Moved Operations Tests into a single file and removed exception handling in sample
- Add type updates from fixit #9991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: documentai Issues related to the Document AI API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants