fixit: Changes to DocAI Samples to simplify maintenence#9743
Merged
Conversation
|
Here is the summary of changes. You are about to add 17 region tags.
You are about to delete 7 region tags.
This comment is generated by snippet-bot.
|
7dc9e4a to
9bbdcf4
Compare
engelke
suggested changes
May 25, 2023
Contributor
engelke
left a comment
There was a problem hiding this comment.
Don't disable flake8 entirely
yil532
reviewed
Jun 5, 2023
- Consolidated process/batch process samples with processor versions - Update Quickstart to include Processor Creation - Consolidate Handle Response Samples into a single file to reduce code duplication - ~Not sure if I did the region tags completely correct, is there a way to test?~ - Update: Tested using Devsite staging and it looks correct - Moved Operations Tests into a single file and removed exception handling in sample - Add type updates from fixit #9991
39e1808 to
cde655e
Compare
| print_lines(page.lines, text) | ||
| print_tokens(page.tokens, text) | ||
|
|
||
| # Currently supported in version `pretrained-ocr-v1.1-2022-09-12` |
Contributor
There was a problem hiding this comment.
Is there a way to state this concept, but not tie it to a specific version that will cause the sample to become stale quickly?
Contributor
Author
There was a problem hiding this comment.
Currently, this feature is only enabled in that version, but not the one that is newer (unless you send a specific parameter that is only enabled on the v1beta3 endpoint...) But supposedly this feature is going to be added to more versions later this quarter.
I could change this to say "only supported in some processor versions, refer to https://cloud.google.com/document-ai/docs/processors-list#processor_doc-ocr for more information" but I wanted to be more specific.
kweinmeister
approved these changes
Jun 21, 2023
Contributor
Author
|
I will also make the docs update to update the sample files. |
engelke
approved these changes
Jun 21, 2023
…docs-samples into docai-processor-versions
6e15ef8 to
64bb497
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if I did the region tags completely correct, is there a way to test?