Skip to content

[firestore] fix: mark 3 tests as flaky #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmatsuo merged 3 commits into from
Apr 8, 2020
Merged

[firestore] fix: mark 3 tests as flaky #3295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47fa332
[firestore] fix: mark 3 tests as flaky
Apr 7, 2020
8c9e7b0
Merge branch 'master' into fix-firestore
crwilcox Apr 8, 2020
963fada
Merge branch 'master' into fix-firestore
Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions firestore/cloud-client/requirements-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
pytest==5.3.2
flaky==3.6.1
3 changes: 3 additions & 0 deletions firestore/cloud-client/snippets_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,19 +267,22 @@ def test_cursor_multiple_conditions():
snippets.cursor_multiple_conditions()


@pytest.mark.flaky(max_runs=3)
def test_listen_document(capsys):
snippets.listen_document()
out, _ = capsys.readouterr()
assert 'Received document snapshot: SF' in out


@pytest.mark.flaky(max_runs=3)
def test_listen_multiple(capsys):
snippets.listen_multiple()
out, _ = capsys.readouterr()
assert 'Current cities in California:' in out
assert 'SF' in out


@pytest.mark.flaky(max_runs=3)
def test_listen_for_changes(capsys):
snippets.listen_for_changes()
out, _ = capsys.readouterr()
Expand Down