[firestore] fix: mark 3 tests as flaky#3295
Merged
Merged
Conversation
fixes GoogleCloudPlatform#3131 These tests are testing sample code that has `sleep(1)` in it. The test is naturally flaky, but when I run the test 100 times, they all pass, so they are somewhat stable. I believe it will mitigate the flakiness a lot just by retrying 3 times. If it doesn't work, we'll probably need to make a fundamental fix to remove `sleep(1)` calls.
crwilcox
approved these changes
Apr 8, 2020
Contributor
|
I am not sure if flaky is working right now but marking these seems like a good call? @leahecole @kurtisvg |
kurtisvg
approved these changes
Apr 8, 2020
Contributor
Is there a reason flaky wouldn't be working? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3131
These tests are testing sample code that has
sleep(1)in it.The test is naturally flaky, but when I run the test 100 times, they all
pass, so they are somewhat stable.
I believe it will mitigate the flakiness a lot just by retrying 3 times.
If it doesn't work, we'll probably need to make a fundamental fix to
remove
sleep(1)calls.