Skip to content

feat:add Live Stream samples#7159

Merged
irataxy merged 6 commits into
GoogleCloudPlatform:mainfrom
irataxy:main
May 20, 2022
Merged

feat:add Live Stream samples#7159
irataxy merged 6 commits into
GoogleCloudPlatform:mainfrom
irataxy:main

Conversation

@irataxy
Copy link
Copy Markdown
Contributor

@irataxy irataxy commented May 20, 2022

Fixes b:219762506

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@irataxy irataxy requested review from a team and yoshi-approver as code owners May 20, 2022 19:02
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label May 20, 2022
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented May 20, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@irataxy irataxy mentioned this pull request May 20, 2022
Closed
9 tasks
@irataxy irataxy assigned kurtisvg and unassigned eaball35 May 20, 2022
kurtisvg
kurtisvg approved these changes May 20, 2022
View reviewed changes
Comment thread media/livestream/src/main/java/com/example/livestream/DeleteInput.java Outdated
Comment thread media/livestream/src/main/java/com/example/livestream/DeleteInput.java
Comment thread media/livestream/src/main/java/com/example/livestream/DeleteInput.java Outdated
Comment thread media/livestream/src/test/java/com/example/livestream/TestUtils.java
irataxy and others added 4 commits May 20, 2022 13:33
@irataxy @kurtisvg
Update media/livestream/src/main/java/com/example/livestream/DeleteIn…
3f4b83f 
…put.java

Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
@irataxy @kurtisvg
Update media/livestream/src/test/java/com/example/livestream/TestUtil…
27a195f 
…s.java

Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
address feedback
0826532
clean up old resources
af44605
@irataxy irataxy merged commit 3882bdf into GoogleCloudPlatform:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

1 more reviewer

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kurtisvg kurtisvg

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@irataxy @kurtisvg @eaball35