Skip to content

feat:add Live Stream samples#7086

Closed
irataxy wants to merge 6 commits into
GoogleCloudPlatform:mainfrom
irataxy:main
Closed

feat:add Live Stream samples#7086
irataxy wants to merge 6 commits into
GoogleCloudPlatform:mainfrom
irataxy:main

Conversation

@irataxy
Copy link
Copy Markdown
Contributor

@irataxy irataxy commented May 2, 2022

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test - allowlisted; contact nickcook@
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

@irataxy irataxy requested review from a team and yoshi-approver as code owners May 2, 2022 22:45
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label May 2, 2022
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented May 2, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 17 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kurtisvg kurtisvg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2022
@kurtisvg kurtisvg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2022
@irataxy
Copy link
Copy Markdown
Contributor Author

irataxy commented May 20, 2022 •
edited
Loading

Refactored in 7159

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@kurtisvg kurtisvg

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@irataxy @kokoro-team @kurtisvg