Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Create data.gouv.fr.xml - #9043

Merged
jeremyn merged 5 commits into
EFForg:masterfrom
nicolasleger:data.gouv.fr
Nov 11, 2017
Merged

jeremyn merged 5 commits into
EFForg:masterfrom
nicolasleger:data.gouv.fr

Conversation

@nicolasleger

Copy link
Copy Markdown
Contributor

No description provided.

@Bisaloo

Bisaloo commented Mar 17, 2017

Copy link
Copy Markdown
Collaborator

Tests fail on this one because you have rules for subdomains you didn't write a target for beforehand. In this case, the subdomains are:

  • data.gouv.fr
  • id.data.gouv.fr

@nicolasleger

Copy link
Copy Markdown
Contributor Author

@Bisaloo Thanks for your help, I fixed it and regroup my commits in one.

<target host="www.data.gouv.fr" />
<target host="adresse.data.gouv.fr" />
<target host="id.data.gouv.fr" />
<target host="inspire.data.gouv.fr" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also:
agd.data.gouv.fr
cada.data.gouv.fr
inspire.data.gouv.fr
static.data.gouv.fr
territoire.data.gouv.fr
webmail.data.gouv.fr

<rule from="^http://data\.gouv\.fr/"
to="https://www.data.gouv.fr/" />
<rule from="^http://id\.data\.gouv\.fr/"
to="https://www.data.gouv.fr/" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment to document why those redirects are required.

@nicolasleger

Copy link
Copy Markdown
Contributor Author

@J0WI sorry I don't have the time yet to re-enter in this, feel free to edit it.

@J0WI

J0WI commented Jul 22, 2017

Copy link
Copy Markdown
Contributor

Done. Maybe @jeremyn or @gloomy-ghost can review my changes.

@jeremyn

jeremyn commented Jul 24, 2017

Copy link
Copy Markdown
Contributor

Sublist3r shows several other domains that aren't included such as https://wiki.data.gouv.fr and https://yak.data.gouv.fr. Do you want to add those (not just those two)?

@J0WI

J0WI commented Oct 29, 2017

Copy link
Copy Markdown
Contributor

I marked it as (partial).

@J0WI

J0WI commented Nov 11, 2017

Copy link
Copy Markdown
Contributor

@jeremyn can we finish this?

@jeremyn

jeremyn commented Nov 11, 2017 •

Copy link
Copy Markdown
Contributor

@jeremyn jeremyn self-assigned this Nov 11, 2017
@J0WI

J0WI commented Nov 11, 2017

Copy link
Copy Markdown
Contributor

Okay, I added one.

@J0WI J0WI closed this Nov 11, 2017
@J0WI J0WI reopened this Nov 11, 2017
@jeremyn
jeremyn merged commit 13d1fd8 into EFForg:master Nov 11, 2017
@jeremyn jeremyn removed their assignment Nov 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants