Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Create cinemasgaumontpathe.com.xml - #9032

Merged
jeremyn merged 3 commits into
EFForg:masterfrom
nicolasleger:cinemasgaumontpathe.com
Jan 25, 2018
Merged

jeremyn merged 3 commits into
EFForg:masterfrom
nicolasleger:cinemasgaumontpathe.com

Conversation

@nicolasleger

Copy link
Copy Markdown
Contributor

No description provided.

@Bisaloo

Bisaloo commented Mar 17, 2017

Copy link
Copy Markdown
Collaborator

same issue as #9043.

@nicolasleger
nicolasleger force-pushed the cinemasgaumontpathe.com branch from f1af9ae to 390472d Compare March 18, 2017 09:30
@nicolasleger

Copy link
Copy Markdown
Contributor Author

@Bisaloo Thanks for your help, I fixed it and regroup my commits in one.

<target host="pro.cinemasgaumontpathe.com" />
<target host="4dx.cinemasgaumontpathe.com" />
<target host="www.4dx.cinemasgaumontpathe.com" />
<target host="m-preprod.cinemasgaumontpathe.com" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also:
intranet.cinemasgaumontpathe.com
webadmin.cinemasgaumontpathe.com

<rule from="^http://cinemasgaumontpathe\.com/"
to="https://www.cinemasgaumontpathe.com/" />
<rule from="^http://4dx\.cinemasgaumontpathe\.com/"
to="https://www.4dx.cinemasgaumontpathe.com/" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document why those redirects are needed.

@J0WI

J0WI commented Jul 8, 2017

Copy link
Copy Markdown
Contributor

@nicolasleger are you still interested to work on this?

@nicolasleger

Copy link
Copy Markdown
Contributor Author

@J0WI sorry I don't have the time yet to re-enter in this, feel free to edit it.

@jeremyn

jeremyn commented Jan 19, 2018

Copy link
Copy Markdown
Contributor

@nicolasleger Are you still interested in working on this pull request? If not, please close this, or we will close this ourselves if we don't hear from you soon. If you want someone else to work on these domains, you can add them to issue #3069.

@J0WI

J0WI commented Jan 19, 2018

Copy link
Copy Markdown
Contributor

@jeremyn I just edited the rule myself.

@jeremyn jeremyn self-assigned this Jan 19, 2018
@jeremyn

jeremyn commented Jan 20, 2018 •

Copy link
Copy Markdown
Contributor

Delete entirely:

Mark as Time out:

Add target:

Also:

  • Sort the targets (the 4dx subdomains should go directly below www)
  • Mark ^ as Secure connection failed in the top comment and remove the comment above the rule
  • Change the ruleset name to CinemasGaumontPathe.com
  • Change the filename to CinemasGaumontPathe.com.xml

@J0WI

J0WI commented Jan 20, 2018

Copy link
Copy Markdown
Contributor

Done.

@jeremyn

jeremyn commented Jan 20, 2018

Copy link
Copy Markdown
Contributor

Thanks @J0WI , this is ready to go.

@nicolasleger Is it okay if I squash-and-merge all of these changes, including @J0WI 's, under your name in one commit?

@nicolasleger

Copy link
Copy Markdown
Contributor Author

Yes all okay, sorry I didn't have the time to get back on those.

@jeremyn
jeremyn merged commit 938f9b9 into EFForg:master Jan 25, 2018
@jeremyn

jeremyn commented Jan 25, 2018

Copy link
Copy Markdown
Contributor

Okay thanks @nicolasleger and @J0WI , merged.

@jeremyn jeremyn removed their assignment Jan 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants