This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Always provide a default value for the chromedriver_path variable#2903
Merged
semenko merged 1 commit intoEFForg:masterfrom Sep 15, 2015
Tenzer:chromedriver-path-lookup
Merged
Always provide a default value for the chromedriver_path variable#2903semenko merged 1 commit intoEFForg:masterfrom Tenzer:chromedriver-path-lookup
semenko merged 1 commit intoEFForg:masterfrom
Tenzer:chromedriver-path-lookup
Conversation
This was discussed in #2901
Contributor
|
LGTM |
Contributor
|
However, can you please remove the extra empty lines? :) |
Contributor
|
WHooooo! Too awesome. 🎀 🎩 👑 👒 👞 🌂 💼 👜 👝 👛 👓 🎣 ☕ 🍵 🍶 🍼 🍺 🍻 🍸 🍹 🍷 🍴 🍕 🍔 🍟 🍗 🍖 🍝 🍛 🍤 🍱 🍣 🍥 🍙 🍘 🍚 🍜 🍲 🍢 🍡 🥚 🍞 🍩 🍮 🍦 |
semenko
added a commit
that referenced
this pull request
Sep 15, 2015
Always provide a default value for the chromedriver_path variable
Contributor
Author
|
@TheNavigat Lines 45-46 AND 75-76 or only one of the sets? I didn't add any blank lines so it's not obvious to me which ones you mean. |
Contributor
|
Line 35, 45, and 75 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the change discussed in #2901.