Ooof, yeah, good call. That logic got pretty silly over a couple of merges (that's a new script since ~last week).

Thanks a bunch!

You're welcome. It could probably be cleaner by putting chromedriver_path = "chromedriver" above the entire if statement, and then scrapping the last two branches, but I wanted to make the change as small as possible.

Yeah -- definitely. Testing got significantly restructured last week, so there are a bunch of hacks hanging around to make things work.

@TheNavigat want to take a look now that Travis/Debian, etc. have been fixed, and see if anything can be cleaned up?

The chromedriver_path = "chromedriver" above the entire if statement is a good idea. However, not doing that has a reason. I simply wanted to make sure that every listed distro is fully supported instead of adding support for distros that might not work. Quite close to the reason why rulesets guides were changed.

Since this PR basically ruins my whole "fully supported distros only" point, you can go ahead and add the whole path setting thing above the if statement.

@semenko Sure, I'll check that in a few!

Oh, sorry, I wasn't aware of that. What does it take to be a fully supported distro then?
One problem with that - at least when using Python 2, is that Arch Linux apparently doesn't fill in a distribution name while it does however work on Python 3:

[jeppe@jeppe ~]$ python2 -c 'import platform; print(platform.linux_distribution())'
('', '', '')
[jeppe@jeppe ~]$ python3 -c 'import platform; print(platform.linux_distribution())'
('arch', '', '')

I disagree with @TheNavigat -- I think it's totally fine to provide a best effort "hey this might work" on other distros.

Clearly people are developing on non-Debian flavors -- and if people want to submit patches to make those distros work better, that's great!

Let's just set chromedriver to look in the path by default -- and if Arch, BSD, etc. run into fun problems, hopefully we'll get equally fun fixes.

@Tenzer, there are no specific rules, but basically I thought that we need to make sure everything works on the distro before adding it to the script.

And that's weird... However, if it works then we're good.

@semenko Alright then, let's do that instead.

I have submitted #2903 which makes the change suggested.