This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Repository navigation
Updates to Politiken.dk and its ad service nugg.ad - #2388
Merged
Merged
Conversation
fuglede
referenced
this pull request
in numismatika/https-everywhere
Aug 12, 2015
Member
|
This PR is failing tests. Do you want to update it or subsume it into https://github.com/EFForg/https-everywhere/pull/2158/files? |
Contributor
Author
|
Updated with tests from #2158. Travis failure appears to be unrelated (tests succeed locally). |
Member
|
Looks good. I re-triggered the test and it passed. Looks like we may have some test flakiness on our hands. :-( |
jsha
added a commit
that referenced
this pull request
Aug 12, 2015
Updates to Politiken.dk and its ad service nugg.ad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nugg.ad ruleset test currently fails due to a lack of tests. I would add those but I am not sure what the intent of the original ruleset is (i.e. what
[\w-]+-s.nuggad.net/is supposed to match).