Repository navigation
Externals 13.07.2015 - #2158
Externals 13.07.2015#2158
Conversation
|
Considering this blocked on the redirect to HTTP. @numismatika, can you run the fetch test on this branch and make sure everything succeeds? |
|
@numismatika: I saw your comments on IRC but I think you're not currently logged in. I'm not sure what's going wrong with the command I suggested. But the goal is to pass each XML file modified in this branch into fetch-test.sh. So you can also do it manually: |
|
At the moment, it ought to be: I got that with: Your diff command also included extraneous changes made in |
|
Correction: |
|
i don't want to turn this into a python support topic, but pip install -r requirements ends up with some weird python issues, pip3 works but python3 can't execute the test scripts. |
|
I removed Nugg.ad for now to avoid merge conflicts. |
|
I pulled this branch and ran fetch-test.sh, and got just one error: |
|
@jsha i removed the subdomain from the Criteo rule now. |
|
@semenko Is it still small enough to be merged? |
99dbf92 to
a7fec81
Compare
|
So i rebased the stuff on top of the current master. |
- add cdn & ups subdomain
- add assets subdomain - fix ruleset style
- remove whitespace
- add pix01 & pq-direct subdomains
- added more subdomains
a7fec81 to
cdb007f
Compare
- remove redundant securecookie comment
- add im2 subdomain & sascdn domains - remove redundant securecookie comments - remove redundant SAS-CDN file
b154a7f to
8a186c1
Compare
|
rebased again to avoid merge conflict |
|
Great, thanks! |
This adds a couple of Subdomains to ad- and tracking networks as well as adds rules for new ones.