Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions src/chrome/content/rules/Phoronix-Media.xml
Original file line number Diff line number Diff line change
@@ -1,25 +1,31 @@
<!--
Nonfunctional:

- (www.)phoronix.net ¹
- (www.)phoronix-media.com ¹
- (www.)phoromatic.com ¹
- (www.)phoronix.com (ssl_error_rx_record_too_long)

¹ Shows blank page; self-signed, CN: phx1.phoronix.com
- (www.)phoronix-test-suite.com ¹
- (www.)phoronix.com/forums (mixed content)

¹ ssl_error_rx_record_too_long
-->
<ruleset name="Phoronix Media (partial)" platform="mixedcontent">

<ruleset name="Phoronix Media">
<target host="phoronix.com" />
<target host="www.phoronix.com" />
<target host="openbenchmarking.org" />
<target host="www.openbenchmarking.org" />

<exclusion pattern="^http://(www\.)?phoronix\.com/forums/" />
<test url="http://phoronix.com/forums/" />
<test url="https://phoronix.com/forums/" />
<test url="http://www.phoronix.com/forums/" />
<test url="https://www.phoronix.com/forums/" />
<rule from="^https://(www\.)?phoronix\.com/forums/" to="http://$1phoronix.com/forums/" downgrade="1" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm this downgrade is necessary? I.e., are there pages on phoronix.com that point incorrectly to the HTTPS version of the forums, causing breakage without it?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTPS version of phoronix.com still links to HTTPS version of the forum even with exclusion pattern (no matter which page on phoronix.com), so I add the downgrade rule. The forum link is often used. It is shown at the site navigation menu on the top of (every) page of phoronix.com. The "Add a comment" on every article of phoronix.com links to forum as well.


<securecookie host="^openbenchmarking\.org$" name=".*" />
<securecookie host="^phoromatic\.com$" name=".*" />


<!-- Michael has noticed our shenanigans and disabled https for pages (unless you pay up).
https://trac.torproject.org/projects/tor/ticket/5728 -->
<rule from="^http://(www\.)?openbenchmarking\.org/(ads/|(?:create/comment/|result/)?css/|embed\.php|favicon\.ico|s/css/)"
to="https://$1openbenchmarking.org/$2" />
<!-- breaks forum
<securecookie host="^.*\.phoronix\.com$" name=".*" />-->
<securecookie host="^.*\.openbenchmarking\.org$" name=".*" />

<rule from="^http:" to="https:" />
</ruleset>
10 changes: 0 additions & 10 deletions src/chrome/content/rules/Phoronix.com.xml

This file was deleted.

1 change: 1 addition & 0 deletions utils/downgrade-whitelist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ NewsBlur
Nextag (self-signed)
NYTimes (breaks comments)
Oak Ridge National Laboratory (partial)
Phoronix Media
Qz.com (partial)
Stack Exchange (partial)
University of Alaska Anchorage (partial)
Expand Down