Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

I18N support for popup.html. German and English. - #1874

Merged
jsha merged 2 commits into
EFForg:masterfrom
Thorsten-Sick:i18n
Jun 17, 2015
Merged

I18N support for popup.html. German and English.#1874
jsha merged 2 commits into
EFForg:masterfrom
Thorsten-Sick:i18n

Conversation

@Thorsten-Sick

Copy link
Copy Markdown
Contributor

We at Avira want to start contributing to HTTPS-Everywhere (Chrome). Here is a first PR (low hanging fruit). More to come.

@reedy

reedy commented Jun 8, 2015

Copy link
Copy Markdown
Contributor

Niiiice 👍

@reedy

reedy commented Jun 12, 2015

Copy link
Copy Markdown
Contributor

I think my only comment here is that you can/should remove the english descriptions directly from the html too.

From popup.html

<section id="UnstableRules" class="rules">
  <h3 i18n="chrome_experimental_rules"></h3>
  <p class="description" i18n="chrome_experimental_rules_description"></p>
</section>

If you do that, I think this should be good to merge :)

@Thorsten-Sick

Copy link
Copy Markdown
Contributor Author

Ok, did that.

@reedy

reedy commented Jun 15, 2015

Copy link
Copy Markdown
Contributor

@jsha Any comments on this? Or am I good to merge it? :D

@jsha

jsha commented Jun 17, 2015

Copy link
Copy Markdown
Member

Thanks so much for your contribution! Merging this.

FYI if you're looking for a next task: I have a pull request #1351 that arranges for Chrome and Firefox to share the same translation infrastructure. This makes it easier for our Transifex community to contribute Chrome translations, and reduces overhead since many of the strings are the same. Feel free to pull that branch and start making the needed changes to make it compatible with this branch. Thanks again,

Jacob

jsha added a commit that referenced this pull request Jun 17, 2015
I18N support for popup.html. German and English.
@jsha
jsha merged commit 446cba2 into EFForg:master Jun 17, 2015
@Thorsten-Sick
Thorsten-Sick deleted the i18n branch June 22, 2015 08:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants