This repository was archived by the owner on Nov 6, 2023. It is now read-only.
I18N support for popup.html. German and English. - #1874
Merged
Conversation
Contributor
|
Niiiice 👍 |
Contributor
|
I think my only comment here is that you can/should remove the english descriptions directly from the html too. From popup.html If you do that, I think this should be good to merge :) |
Contributor
Author
|
Ok, did that. |
Contributor
|
@jsha Any comments on this? Or am I good to merge it? :D |
Member
|
Thanks so much for your contribution! Merging this. FYI if you're looking for a next task: I have a pull request #1351 that arranges for Chrome and Firefox to share the same translation infrastructure. This makes it easier for our Transifex community to contribute Chrome translations, and reduces overhead since many of the strings are the same. Feel free to pull that branch and start making the needed changes to make it compatible with this branch. Thanks again, Jacob |
jsha
added a commit
that referenced
this pull request
Jun 17, 2015
I18N support for popup.html. German and English.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We at Avira want to start contributing to HTTPS-Everywhere (Chrome). Here is a first PR (low hanging fruit). More to come.