Share translations between Chrome & FF - #1351
Conversation
|
Also, fair notice: I haven't actually tested these translations because I couldn't figure out how to set the interface language in Chromium. Help appreciated! |
|
Cool -- will test more in a bit. IIRC you can change the language at chrome://settings/languages |
|
Unfortunately chrome://settings/languages only changes my Accept-Language header, it doesn't seem to change the interface language. This is on Linux with Chromium and Chrome, both. Does it work differently for you? |
|
Hm, good call. I got this to work exporting a LANGUAGE= variable on Linux. I also set a temporary user profile directory:
The |
|
Awesome, this worked, thanks! Here's a neat trick to make it easier:
Builds the extension and runs it in a temporary profile. It seems to be missing the "Stable rules" / "Experimental rules" translations for ES at least. That sort of makes sense - they haven't been translated - but ideally it should have the English strings there rather than blank space. I'll take a look next week. |
|
Fixes #1207 |
|
Can you resolve the conflicts in this PR? |
Also incorporate the handful of unique-to-chromium messages into FF dtd, and remove some obsolete messages.
bb3c4a4 to
804b0f9
Compare
|
Okay, brought this branch up-to-date with the latest code. Note: The newly added strings (e.g. "Stable rules") will show up as blank in non-English languages at the moment. Once this change hits master, Transifex will pick up the new strings and add them to all locales. So, once we update the |
|
I'm seeing blanks for "Stable Rules" in Chrome. Looks like the HTML is prefixed with
|
|
Fixed, thanks. |
Share translations between Chrome & FF
|
FYI, I think this broke the "Add new rule" button in chrome (because it wasn't prefixed by chrome_). I might fix in a bit. |
Most of the messages for i18n are the same between Chrome and Firefox. This automates turning the Firefox local files into Chrome ones at build time, so Chrome will always have the same translations FF does, and the benefit of the larger translation community.
This removes one message that was unique to Chrome ("What is this?"), replacing it with "About HTTPS Everywhere." It also copies four other unique-to-Chrome messages into the FF locale files, preserving the already-translated copies of those.
cc @semenko @cooperq @diracdeltas