Skip to content

Use pinned ffmpeg version in CI #3276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexEMG merged 3 commits into from
Apr 10, 2026
Merged

Use pinned ffmpeg version in CI #3276

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42fd1fc
Pin Windows FFmpeg build and use literal paths
C-Achard Apr 8, 2026
347e545
Update python-package.yml
C-Achard Apr 8, 2026
b93ab9f
Point to proper file for March 26 release
C-Achard Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,16 +124,21 @@ jobs:
elif [ "$RUNNER_OS" == "macOS" ]; then
brew install ffmpeg || true
fi
- name: Install ffmpeg (Windows, BtbN latest)
- name: Install ffmpeg (Windows, pinned monthly BtbN build)
# NOTE: The pinned version should be retained for ~2 years. This WILL fail if the BtbN release is removed,
# so if you are two years in the future and this step fails, please check the builds. Thanks.
if: runner.os == 'Windows'
shell: pwsh
env:
FFMPEG_ASSET: ffmpeg-master-latest-win64-gpl-shared.zip
FFMPEG_TAG: autobuild-2026-03-31-13-11
FFMPEG_ASSET: ffmpeg-N-123777-g53537f6cf5-win64-gpl-shared.zip
run: |
$ErrorActionPreference = "Stop"

$tag = $env:FFMPEG_TAG
$asset = $env:FFMPEG_ASSET
$baseUrl = "https://github.com/BtbN/FFmpeg-Builds/releases/latest/download"

$baseUrl = "https://github.com/BtbN/FFmpeg-Builds/releases/download/$tag"
$url = "$baseUrl/$asset"
$checksumsUrl = "$baseUrl/checksums.sha256"

Expand All @@ -142,13 +147,15 @@ jobs:
$checksums = Join-Path $tmpRoot "checksums.sha256"
$dest = Join-Path $tmpRoot "ffmpeg"

if (Test-Path $tmpRoot) { Remove-Item -Recurse -Force $tmpRoot }
if (Test-Path -LiteralPath $tmpRoot) {
Remove-Item -LiteralPath $tmpRoot -Recurse -Force
}
New-Item -ItemType Directory -Path $tmpRoot | Out-Null

Invoke-WebRequest -Uri $url -OutFile $zip
Invoke-WebRequest -Uri $checksumsUrl -OutFile $checksums

$expected = Get-Content -Path $checksums |
$expected = Get-Content -LiteralPath $checksums |
ForEach-Object {
if ($_ -match '^(?<sha>[0-9A-Fa-f]{64})\s+\*?(?<name>.+)$' -and $matches.name.Trim() -eq $asset) {
$matches.sha.ToLowerInvariant()
Expand All @@ -160,14 +167,16 @@ jobs:
throw "Could not find checksum for $asset in $checksums"
}

$actual = (Get-FileHash -Path $zip -Algorithm SHA256).Hash.ToLowerInvariant()
$actual = (Get-FileHash -LiteralPath $zip -Algorithm SHA256).Hash.ToLowerInvariant()
if ($actual -ne $expected) {
throw "FFmpeg checksum mismatch. Expected $expected but got $actual"
}

Expand-Archive -Path $zip -DestinationPath $dest -Force
$ffdir = Get-ChildItem -Path $dest -Directory | Select-Object -First 1
if (-not $ffdir) { throw "Could not find extracted FFmpeg directory." }
Expand-Archive -LiteralPath $zip -DestinationPath $dest -Force
$ffdir = Get-ChildItem -LiteralPath $dest -Directory | Select-Object -First 1
if (-not $ffdir) {
throw "Could not find extracted FFmpeg directory."
}

$binDir = Join-Path $ffdir.FullName "bin"
$binDir | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
Expand Down
Loading