Use pinned ffmpeg version in CI - #3276
Merged
Merged
Conversation
Pin the Windows FFmpeg installer to a specific monthly BtbN build (FFMPEG_TAG) and switch from the "latest" releases download to the tagged /download/$tag URL. Harden PowerShell file operations by using -LiteralPath for Test-Path, Remove-Item, Get-Content, Get-FileHash, Expand-Archive and Get-ChildItem, add safer Remove-Item handling, and fail if no extracted FFmpeg directory is found. These changes improve reproducibility and make the downloader more robust against path/filename edge cases.
C-Achard
marked this pull request as ready for review
April 9, 2026 07:17
deruyter92
approved these changes
Apr 10, 2026
Collaborator
|
@C-Achard agreed as discussed, thanks for implementing. We should merge this one as soon as possible, as it obstructs running CI tests a few hours per day. |
AlexEMG
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Due to the way the BtBn ffmpeg build CI is written, there is a ~2-3 hours gap in the day, starting around 1 PM CEST, where the latest release URL points to the previous build rather than the latest, a drift that causes the download to fail in our CI, as the files in the "latest" release do not have the correct name.
Proposed solution
To alleviate this, the PR installs a pinned version of ffmpeg from BtBn which should be valid for roughly 2 years, limiting the impact for build downloads. (Includes a note to update in two years.)
Alternatives
We could revert to Chocolatey or Winget, but with some retry logic to account for sporadic download failures.