-
-
Notifications
You must be signed in to change notification settings - Fork 620
ZA2-Berenice-Ogundele_HTML-CSS-Module-Project-WK2 #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BereniceOgundele
wants to merge
15
commits into
CodeYourFuture:master
Choose a base branch
from
BereniceOgundele:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6bbb410
Headings
BereniceOgundele cec3cd1
Nav bar
BereniceOgundele 6720f99
moved nav links
BereniceOgundele 5baf3e4
img tags
BereniceOgundele 4bda6e6
social media handles
BereniceOgundele 9fa53e3
x3 icons
BereniceOgundele 3407a5c
karma logo
BereniceOgundele 87542d5
navigation styling
BereniceOgundele 624214c
introduction styling
BereniceOgundele 8f6b0c1
button styling
BereniceOgundele 43cb4f5
devices styling
BereniceOgundele 1f94648
social styling
BereniceOgundele 6fbd342
nav bar errors
BereniceOgundele fec46d2
added text on footer
BereniceOgundele 3cdc3b8
added Karma detail at footer
BereniceOgundele File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,11 +9,82 @@ | |
| <link rel="stylesheet" href="css/style.css"> | ||
| <link rel="shortcut icon" type="image/x-icon" href="favicon.ico"> | ||
| </head> | ||
| <nav class="top-navigation"> | ||
| <div class="content"> | ||
| <ul class="links"> | ||
| <li class="active">Meet Karma</li> | ||
| <li>How it Works</li> | ||
| <li>Store</li> | ||
| <li>Blog</li> | ||
| <li>Help</li> | ||
| <li>Login</li> | ||
| </ul> | ||
| <img class="logo" src="https://thinkful-ed.github.io/karma-clone/img/karma-logo.svg" alt="Logo image" width="26"> | ||
| </div> | ||
| </nav> | ||
|
|
||
| <body> | ||
| <header> | ||
| <section class="introduction"> | ||
| <div class="content"> | ||
| </div> | ||
| <h1>Introducing Karma</h1> | ||
| <h3>Bring WiFi with you, everywhere you go</h3> | ||
| <button>Learn More!</button> | ||
| </header> | ||
| </section> | ||
|
|
||
| <section class="stories"> | ||
| <div> | ||
| <h2>Everyone needs a little Karma<h/2> | ||
| <ul class="devices"> | ||
| <li> | ||
| <img src="https://thinkful-ed.github.io/karma-clone/img/icon-devices.svg" alt="devices" width="127" height="127"> | ||
| <h3>Internet for all devices</h3> | ||
| </li> | ||
|
|
||
| <li> | ||
| <img src="https://thinkful-ed.github.io/karma-clone/img/icon-coffee.svg" alt="productivity" width="127" height="127"> | ||
| <h3>Boost your Productivity</h3> | ||
| </li> | ||
|
|
||
| <li> | ||
| <img src="https://thinkful-ed.github.io/karma-clone/img/icon-refill.svg" alt="refill" width="127" height="127"> | ||
| <h3>Pay as you go</h3> | ||
| </li> | ||
|
|
||
|
|
||
| </ul> | ||
|
|
||
|
|
||
| </div> | ||
| </section> | ||
|
|
||
|
|
||
|
|
||
| <!-- Add your HTML markup here --> | ||
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
| <!-- All the images you need are in the 'img' folder --> | ||
|
|
||
| </body> | ||
|
|
||
| <footer class="social"> | ||
| <hr> | ||
| <h4>Join us on</h4> | ||
| <div class="content"> | ||
| <ul class="icons"> | ||
| <li class="twitter"> | ||
| <i class=" fa fa-twitter"></i> | ||
| </li> | ||
| <li class="twitter"> | ||
| <i class="fa fa-facebook"></i> | ||
| </li> | ||
| <li class="twitter"> | ||
| <i class="fa fa-instagram"></i> | ||
| </li> | ||
| </ul> | ||
| </div> | ||
| <p>Karma Mobility.Inc</p> | ||
| </footer> | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Overall well done Berry, think we both getting the hang of things now |
||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Berry, very well done on your work, according to the light house reports of last week they said to me it is best practice to have your H1 tags first then your H2 tags and then your H3 tags, but I could be wrong and need to look at it myself again