ZA2-Berenice-Ogundele_HTML-CSS-Module-Project-WK2#375
Open
BereniceOgundele wants to merge 15 commits into
Open
ZA2-Berenice-Ogundele_HTML-CSS-Module-Project-WK2#375BereniceOgundele wants to merge 15 commits into
BereniceOgundele wants to merge 15 commits into
Conversation
When I looked at the web browser, the nav links was "inside the content, so i moved it out.
I created a div containing the social media handles
logo url taken from github site
done
done
updated, but not working properly. need to check/fix
struggling to fix
saw that I omitted "join us on", so i added thi as a <h4>
I could not add the copyright symbol, will look for a way to to it and add later, Lordwilling
| <div class="content"> | ||
| </div> | ||
| <h1>Introducing Karma</h1> | ||
| <h3>Bring WiFi with you, everywhere you go</h3> |
There was a problem hiding this comment.
Hi Berry, very well done on your work, according to the light house reports of last week they said to me it is best practice to have your H1 tags first then your H2 tags and then your H3 tags, but I could be wrong and need to look at it myself again
| </ul> | ||
| </div> | ||
| </footer> | ||
|
|
There was a problem hiding this comment.
Overall well done Berry, think we both getting the hang of things now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?