feat: allow external signer to sign for multiple wallet ids - #1988
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1988 +/- ##
===========================================
+ Coverage 0 87.43% +87.43%
===========================================
Files 0 177 +177
Lines 0 9449 +9449
Branches 0 1357 +1357
===========================================
+ Hits 0 8262 +8262
- Misses 0 783 +783
- Partials 0 404 +404
Flags with carried forward coverage won't be shown. Click here to find out more.
|
have the external signer read the private key from the wallet id. This allows the external signer to produce signatures for multiple wallets. Ticket: BG-42962
DariusParvin
force-pushed
the
BG-42962-read-prv-from-walletid
branch
from
February 10, 2022 22:32
501de39 to
735dcd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the external signer would produce signatures using the single private key provided in the json file (specified by the config arg
signerFileSystemPath). Now, it'll find the appropriate private key corresponding to thewalletIdfor the transaction being signed and use that private key.Note: Only the last commit corresponds to this PR. The previous commits are from #1944 waiting to be merged