feat: add external signing functionality for v2 wallet - #1944
Merged
Conversation
DariusParvin
force-pushed
the
BG-42470-add-external-signing-function
branch
from
February 2, 2022 19:50
472b540 to
8d6c237
Compare
Codecov Report
@@ Coverage Diff @@
## master #1944 +/- ##
===========================================
+ Coverage 0 53.93% +53.93%
===========================================
Files 0 5 +5
Lines 0 534 +534
Branches 0 82 +82
===========================================
+ Hits 0 288 +288
- Misses 0 242 +242
- Partials 0 4 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DariusParvin
force-pushed
the
BG-42470-add-external-signing-function
branch
3 times, most recently
from
February 2, 2022 21:55
dbf841e to
56e32ff
Compare
tylerlevine
reviewed
Feb 3, 2022
Contributor
There was a problem hiding this comment.
nit: this is no longer necessary and can be removed from all other errors defined here. Please remove in a follow up PR though, no need to do this clean up item here
DariusParvin
force-pushed
the
BG-42470-add-external-signing-function
branch
from
February 7, 2022 05:54
8a369e8 to
42a81da
Compare
Contributor
Author
|
Thanks for the feedback! I added changes (and a test) that require express to be in test mode when using the external signer feature. I'll create a separate PR for removing the unnecessary |
added 4 commits
February 8, 2022 15:24
add signing functionality to handleV2Sign. Ticket: BG-42470
prevent express from starting up with an invalid config with respect to external signer flags. Ticket: BG-42470
When express is acting as an external signer, signerFileSystemPath should containt the path to the user's private key. Ticket: BG-42470
DariusParvin
force-pushed
the
BG-42470-add-external-signing-function
branch
from
February 8, 2022 23:24
42a81da to
7b00932
Compare
tylerlevine
approved these changes
Feb 10, 2022
Comment on lines
+240
to
+244
| try { | ||
| checkSignerPrvPath(signerFileSystemPath); | ||
| } catch (e) { | ||
| throw e; | ||
| } |
Contributor
There was a problem hiding this comment.
No need to catch if you're just going to immediately rethrow - feel free to handle in a follow up PR to clean up some other nits as well.
Suggested change
| try { | |
| checkSignerPrvPath(signerFileSystemPath); | |
| } catch (e) { | |
| throw e; | |
| } | |
| checkSignerPrvPath(signerFileSystemPath); |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleV2SignsignerFileSystemPathargument on startup to make sure it contains a JSON file with a "prv" field