Add Muhammad Maaz to Before I Die#196
Conversation
|
@maazshakeel is attempting to deploy a commit to the Before I Die Code Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@maazshakeel You did everything correctly. I needed to add contributors to avoid a merge conflict.
There was a problem hiding this comment.
@maazshakeel Everything was done correctly and I updated the list with a few other contributors to avoid a merge conflict.
There was a problem hiding this comment.
Hahaha, I'm not entirely sure if this is good to add, as the repo didn't have a yarn.lock file before with all the dependencies, but I'be run into the issue of missing up the dependency packages before when merging pull requests from other contributors, and when searching online, it seems like a good option to include this file for now.
XanderRubio
left a comment
There was a problem hiding this comment.
Great job @maazshakeel! I really appreciate the time you took to share your goals and aspirations, both in text and image. You are certainly on the right track, especially at such a young age. My recommendation would be to continue learning every day and to make as many mistakes as possible in order to grow and develop. As a young person, you have the flexibility to quickly learn new skills and apply them in successful ventures. I'm happy to proceed with merging now!
|
@XanderRubio Thanks a lot mate, I really appreciate it! |
|
@maazshakeel Your pull request has been successfully merged!!! Congratulations If you haven't already, please go ahead and star |
|
Thanks once again! Its an honor for me to be a member of Before I Die community. Appreciate it! 🎉 |
The pleasure is all mine and thank you! |
Issue Addressed
Closes #5