Skip to content

Add Muhammad Maaz to Before I Die #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XanderRubio merged 4 commits into from
Oct 13, 2023
Merged

Add Muhammad Maaz to Before I Die #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00ad36a
Add Muhammad Maaz to Before I Die
maazshakeel Oct 13, 2023
3468103
Update CONTRIBUTORS.md
XanderRubio Oct 13, 2023
1e42234
Update Contributors.json
XanderRubio Oct 13, 2023
caae988
Merge branch 'main' into add-muhammad-maaz
XanderRubio Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Copy link
Copy Markdown
Member

@XanderRubio XanderRubio Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maazshakeel You did everything correctly. I needed to add contributors to avoid a merge conflict.

Original file line number Diff line number Diff line change
Expand Up @@ -677,5 +677,17 @@
</a>
</td>
<!-- End of column-3 -->
<!-- Start of column-4 -->
<td align="center">
<a href="https://github.com/maazshakeel">
<img
src="https://avatars.githubusercontent.com/u/62890173?v=4"
width="100px"
/>
<br />
<sub>Muhammad Maaz</sub>
</a>
</td>
<!-- End of column-4 -->
</tr>
</table>
Binary file added public/img/avatar/maaz.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/img/bid_image/maaz.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions src/Jsons/Contributors.json
View file
Open in desktop
Copy link
Copy Markdown
Member

@XanderRubio XanderRubio Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maazshakeel Everything was done correctly and I updated the list with a few other contributors to avoid a merge conflict.

Original file line number Diff line number Diff line change
Expand Up @@ -502,5 +502,14 @@
"location": "London, England 🇬🇧",
"GitHub": "https://github.com/ben-dh3",
"text": "I want to create a body of work I can be proud of... works of art - books and paintings. I want to be able to say - I've made the most of my gifts. I have done what I was put on this earth to do."
},
{
"id": "Muhammad Maaz",
"image": "img/bid_image/maaz.jpg",
"avatar": "img/avatar/maaz.jpg",
"name": "Muhammad Maaz",
"location": "Punjab, Pakistan 🇵🇰",
"GitHub": "https://github.com/maazshakeel",
"text": "Leave an impact on this Earth with my skills!"
}
]
Loading