Skip to content

TRD raw data should be one file per CRU end point#9822

Merged
martenole merged 1 commit into
AliceO2Group:devfrom
martenole:fst
Sep 15, 2022
Merged

TRD raw data should be one file per CRU end point#9822
martenole merged 1 commit into
AliceO2Group:devfrom
martenole:fst

Conversation

@martenole
Copy link
Copy Markdown
Contributor

No description provided.

@martenole martenole requested a review from a team as a code owner September 14, 2022 14:27
davidrohr
davidrohr previously approved these changes Sep 14, 2022
Copy link
Copy Markdown
Collaborator

@davidrohr davidrohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. So we need new datasets for SYNTHETIC?

@martenole
Copy link
Copy Markdown
Contributor Author

Depends.. Do you still have the simulation files lying around? Then I could run o2-trd-trap2raw manually again to get the correct files. Otherwise we would need new synthetics, yes. But for the single TFs I could also produce them

@martenole martenole changed the title TRD raw data should be one file per CRU end point [WIP] TRD raw data should be one file per CRU end point Sep 14, 2022
@martenole
Copy link
Copy Markdown
Contributor Author

Not to be merged yet

@davidrohr
Copy link
Copy Markdown
Collaborator

for reference, all files in /home/drohr/raw/new*/TRD*` have been regenerated, with 1 file per endpoint, for usage in SYNTHETIC runs.

@martenole martenole changed the title [WIP] TRD raw data should be one file per CRU end point TRD raw data should be one file per CRU end point Sep 14, 2022
@martenole
Copy link
Copy Markdown
Contributor Author

To be consistent with the other detectors, the option o2-trd-trap2raw --file-per cru produces now one file per CRU end point. This is what the readout is expecting and what is done in the FST

Copy link
Copy Markdown
Collaborator

@bazinski bazinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this option change is confusing, but apparently we must change to be confusing like everyone else ...

@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2/o2 for 687418f at 2022-09-14 21:27:

## sw/BUILD/O2-latest/log
100% tests passed, 0 tests failed out of 450
 94/106 Test #108: test_Framework_test_SingleDataSource ....................***Failed    2.92 sec
[ERROR] pid 26894 (internal-dpl-injected-dummy-sink) crashed with 1
[ERROR] SEVERE: Device internal-dpl-injected-dummy-sink (26894) returned with 1
99% tests passed, 1 tests failed out of 101

Full log here.

@martenole
Copy link
Copy Markdown
Contributor Author

I think this option change is confusing, but apparently we must change to be confusing like everyone else ...

I agree :(

@martenole martenole merged commit 8a96fc0 into AliceO2Group:dev Sep 15, 2022
@davidrohr
Copy link
Copy Markdown
Collaborator

I think this option change is confusing, but apparently we must change to be confusing like everyone else ...

I agree :(

we can also change it for all detectors, or just rename the cru option to cruendpoint everywhere...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants