FST MC->Raw files are produced by CRU end point#9834
Merged
Conversation
bazinski
approved these changes
Sep 15, 2022
Collaborator
|
Error while checking build/O2/fullCI for 33c16e5 at 2022-09-16 10:51: Full log here. |
Collaborator
|
Error while checking build/O2/o2-dataflow for 33c16e5 at 2022-09-21 08:11: Full log here. |
Collaborator
|
Error while checking build/O2/o2 for 33c16e5 at 2022-09-21 05:57: Full log here. |
Collaborator
|
Error while checking build/AliceO2/O2/o2/macOS-arm for 33c16e5 at 2022-09-18 00:08: Full log here. |
Contributor
Author
|
If there are no comments or objections I would merge this tomorrow |
rpezzi
approved these changes
Sep 20, 2022
davidrohr
approved these changes
Sep 20, 2022
Contributor
Author
|
Failure unrelated and all checks were green before, merging |
Collaborator
|
Thx, this makes sense to me. Eventually one should also check why hmpid uses the link differently and homogenize that as well. But can be done as follow-up.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating new synthetic data samples we noticed inconsistencies in the option naming scheme of different detectors.
By default, when creating raw data for readout at P2 we require the files per CRU end point. Thus the option
cruused by most detectors to describe this has been changed tocruendpoint.For HMPID I use
crorcendpointinstead ofcru. I did not uselinkas the other CROC detectors do, because that option is used by something else for HMPID.Please let me know in case you have comments or prefer to keep the options as they are now. There was some initial discussion in #9822