Skip to content

Splitting of GRP object #7287

Merged
shahor02 merged 10 commits into
AliceO2Group:devfrom
chiarazampolli:GRPECS
Nov 12, 2021
Merged

Splitting of GRP object #7287
shahor02 merged 10 commits into
AliceO2Group:devfrom
chiarazampolli:GRPECS

Conversation

@chiarazampolli
Copy link
Copy Markdown
Collaborator

@chiarazampolli chiarazampolli commented Oct 12, 2021

Object to fill information from ECS, see https://alice.its.cern.ch/jira/browse/OCTRL-564

@chiarazampolli
Adding GRPECSObject
4ffbb28 
clang-format
@chiarazampolli chiarazampolli requested review from a team and shahor02 as code owners October 12, 2021 14:10
shahor02
shahor02 reviewed Oct 13, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chiarazampolli !
Please see a few comments below

Comment thread DataFormats/Parameters/include/DataFormatsParameters/GRPECSObject.h Outdated
Comment thread macro/CreateGRPECSObject.C Outdated
Comment thread macro/CreateGRPECSObject.C
shahor02
shahor02 reviewed Oct 13, 2021
View reviewed changes
Comment thread macro/CreateGRPECSObject.C Outdated
@chiarazampolli
Copy link
Copy Markdown
Collaborator Author

chiarazampolli commented Oct 15, 2021

Hi @shahor02 ,

I moved this PR to WIP, I would add here the split to the MagField GRP object and some changes in the LHCIF object, to avoid too many PRs.

Chiara

@chiarazampolli chiarazampolli changed the title Adding GRPECSObject [WIP] Adding GRPECSObject Oct 15, 2021
@chiarazampolli chiarazampolli changed the title [WIP] Adding GRPECSObject [WIP] Splitting of GRP object Oct 19, 2021
@chiarazampolli
Copy link
Copy Markdown
Collaborator Author

chiarazampolli commented Oct 19, 2021

Hello @shahor02 .
I implemented the filling of the Bunch Filling information in the LHCIF part of GRP. I need to wait for https://github.com/AliceO2Group/AliceO2/pull/7367/files to be merged, then I can fix the (anti)clockwise) beam indices.
Last to be implemented is the workflow for filling the B field information. Then I think we have everything - to be reviewed, of course.
Chiara

@chiarazampolli
Copy link
Copy Markdown
Collaborator Author

chiarazampolli commented Nov 2, 2021 •
edited
Loading

Hi @shahor02 ,

In this PR I added the change for the path of the MeanVertex.
BTW, what if I remove the [WIP] from this PR, and we use another one for the processing of the B field Data Points?

Chiara

@shahor02
Copy link
Copy Markdown
Collaborator

shahor02 commented Nov 2, 2021

@chiarazampolli thanks! BTW, the MeanVertexObject (and calibrator) should be eventually changed to account for the diamond slopes.
OK for removing WIP and eventually merging.

@shahor02 shahor02 mentioned this pull request Nov 3, 2021
Merged
@shahor02 shahor02 changed the title [WIP] Splitting of GRP object Splitting of GRP object Nov 10, 2021
shahor02
shahor02 approved these changes Nov 12, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failures are unrelated.

@shahor02 shahor02 merged commit 795c737 into AliceO2Group:dev Nov 12, 2021
ezradlesser pushed a commit to ezradlesser/AliceO2 that referenced this pull request Dec 2, 2021
@chiarazampolli @iravasen
Merge pull request AliceO2Group#7287 from chiarazampolli/GRPECS
1e38297 
Splitting of GRP object
@chiarazampolli chiarazampolli deleted the GRPECS branch May 16, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 shahor02 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chiarazampolli @shahor02