helper to get nominal L3 field#7506
Merged
Merged
Conversation
shahor02
reviewed
Nov 3, 2021
Comment on lines
+162
to
+163
| int8_t mNominalL3Field = 0; ///< Nominal L3 field deduced from mL3Current | ||
| bool mNominalL3FieldValid = false; ///< Has the field been computed (for caching) |
Collaborator
There was a problem hiding this comment.
fine for me, but please make it
int8_t mNominalL3Field = 0; //! Nominal L3 field deduced from mL3Current
bool mNominalL3FieldValid = false; //! Has the field been computed (for caching)
to not store on-line values.
Note that this object will be eventually discarded, @chiarazampolli splits is to a few objects according to data provenance: #7287
Collaborator
Author
There was a problem hiding this comment.
Done. @chiarazampolli can you port also this addition, then?
wiechula
requested changes
Nov 3, 2021
Co-authored-by: wiechula <11199190+wiechula@users.noreply.github.com>
ezradlesser
pushed a commit
to ezradlesser/AliceO2
that referenced
this pull request
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.