Skip to content

Code owners - #2357

Merged
sawenzel merged 4 commits into
AliceO2Group:devfrom
ihrivnac:code-owners
Sep 4, 2019
Merged

Code owners#2357
sawenzel merged 4 commits into
AliceO2Group:devfrom
ihrivnac:code-owners

Conversation

@ihrivnac

Copy link
Copy Markdown
Contributor

Completed file including detector responsibles.
See also O2-816

@ihrivnac
ihrivnac requested a review from a team as a code owner August 30, 2019 14:39

@davidrohr davidrohr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is OK for the start. Can be adjusted when needed.

Corrected user name swenzel -> sawenzel
@sawenzel

sawenzel commented Sep 3, 2019

Copy link
Copy Markdown
Collaborator

My username was not correct. I fixed it directly in the file.

@ktf

ktf commented Sep 3, 2019

Copy link
Copy Markdown
Member

I think we should not use actual usernames, but groups, at least in general.

@ihrivnac

ihrivnac commented Sep 3, 2019

Copy link
Copy Markdown
Contributor Author

HI @ktf,
Could you, please, post your comment in the dedicated JIRA ticket linked above? As this is already the 3rd PR related to this topic, I think it is better to keep the discussion at one place.
Thank you,

@ktf

ktf commented Sep 3, 2019

Copy link
Copy Markdown
Member

Done. I've locked the conversation so that no one posts here.

@AliceO2Group AliceO2Group locked and limited conversation to collaborators Sep 3, 2019
@sawenzel

sawenzel commented Sep 4, 2019

Copy link
Copy Markdown
Collaborator

Going ahead after the discussion in WP3.

@sawenzel
sawenzel merged commit f50cf33 into AliceO2Group:dev Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants