Skip to content

Add attempted code owner for MUON - #2333

Closed
ktf wants to merge 1 commit into
devfrom
ktf-patch-1
Closed

Add attempted code owner for MUON#2333
ktf wants to merge 1 commit into
devfrom
ktf-patch-1

Conversation

@ktf

@ktf ktf commented Aug 22, 2019

Copy link
Copy Markdown
Member

No description provided.

@ktf
ktf requested a review from a team as a code owner August 22, 2019 21:53
@ktf

ktf commented Aug 22, 2019

Copy link
Copy Markdown
Member Author

@ihrivnac @aphecetche I guess we agree on this.

@ktf
ktf requested a review from aphecetche August 22, 2019 21:54
@ktf
ktf requested a review from ihrivnac August 23, 2019 10:19
@ktf

ktf commented Aug 23, 2019

Copy link
Copy Markdown
Member Author

@ihrivnac unless you strongly object, I would try to merge this and similar PRs without having to wait for the full list of interested parties, because otherwise I get spammed as "fall back solution".

@ihrivnac ihrivnac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
There is no doubt about adding Laurent here, but I'd prefer to avoid multiple PR's for updating this file. To avoid you being spammed as "fall back solution", we can modify the file and inactivate all lines below the first one, which directs everything to "core".
Would this work for you?

@ktf

ktf commented Aug 23, 2019

Copy link
Copy Markdown
Member Author

Apart from the fact that I do want to be notified as "core" if some of the top-level files change (e.g. the travis and codecov stuff), removing core means that people will be able to add new files and folders at top-level, which for sure we want to catch.

@ktf

ktf commented Aug 23, 2019

Copy link
Copy Markdown
Member Author

What is the issue with the incremental approach, out of curiosity?

@ihrivnac

Copy link
Copy Markdown
Contributor

I did not propose to remove core.
The global approach (which was setup in the WIP PR) would have the advantage that we would keep all comments/discussion related to this at a single place.

@ktf

ktf commented Aug 23, 2019

Copy link
Copy Markdown
Member Author

Can't we have a JIRA ticket for that?

@ihrivnac

Copy link
Copy Markdown
Contributor

The JIRA ticket already exists (was create at the same time as the WIP PR):
O2-816

@ktf

ktf commented Aug 23, 2019

Copy link
Copy Markdown
Member Author

Anyways, as you prefer. If it's matter of a few days I guess I can survive with a few extra emails.

@sawenzel

sawenzel commented Sep 3, 2019

Copy link
Copy Markdown
Collaborator

This is now part of #2357. I guess we can close this.

@sawenzel sawenzel closed this Sep 3, 2019
@ktf
ktf deleted the ktf-patch-1 branch October 3, 2019 20:08
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Apr 15, 2023
* [PWGEM-10] Add EMCal cluster cuts to new CutLibrary
- Add the EMCal cluster cuts to new CutLibrary started by Daiki (PR AliceO2Group#2307)

* [PWGEM-10] Fix MegaLinter Errors for PR AliceO2Group#2333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants