Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

feat: add v3#62

Merged
gcf-merge-on-green[bot] merged 4 commits intomasterfrom
add-v3
Jun 10, 2021
Merged

feat: add v3#62
gcf-merge-on-green[bot] merged 4 commits intomasterfrom
add-v3

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Jun 6, 2021 •
edited
Loading

Fixes #2 🦕

This PR adds the auto generated v3 client for Resource Manager and changes the release status from alpha to beta. This is a significant change from the previous version v1beta1, as this is the first version of an auto generated client.

chore(release_status): upgrade release status from alpha to beta
fix: remove v1beta1
chore(deps): require python 3.6+

@parthea parthea requested a review from a team June 6, 2021 10:00
@product-auto-label product-auto-label bot added the api: cloudresourcemanager Issues related to the googleapis/python-resource-manager API. label Jun 6, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 6, 2021
@parthea parthea added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2021
@parthea parthea mentioned this pull request Jun 6, 2021
Closed
4 tasks
busunkim96
busunkim96 approved these changes Jun 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! Glad to see this get added.

Was the decision to delete all the existing code and take the breaking change?

@parthea
Copy link
Copy Markdown
Contributor Author

parthea commented Jun 7, 2021

@busunkim96 Yes, we decided to take this breaking change since this repository is at release level 'alpha'. Users can pin google-cloud-resource-manager<1.0.0 to avoid taking the breaking change. In addition, we want to roll this out using a pre-release so that only users that install using pip install --pre will receive it initially. I'm going to hold off on merging this until I'm ready for the pre-release.

cc @danoscarmike

@parthea
Copy link
Copy Markdown
Contributor Author

parthea commented Jun 8, 2021

In preparation for the pre-release, I've successfully published a pre-release to testpypi here for demonstration purposes. It looks like we need to add the suffix rc<version> to the version in order for it to be a pre-release, eg. 1.0.0rc1. We would need to have separate versioning strategies in release-please for stable and release candidate versions. For example, release candidates would increment like this 1.0.0rc1 , 1.0.0rc2… etc instead of 1.0.0 , 1.0.1 etc. I'm going to put this PR on hold while I figure out how to handle release candidates with release-please. There is a an open PR in release-please which may help : googleapis/release-please#903 .

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 8, 2021
@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Jun 10, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 10, 2021
@parthea
Copy link
Copy Markdown
Contributor Author

parthea commented Jun 10, 2021

In order for release-please to handle pre-releases we need to include a - in the version number. See here. I'm going to merge this PR and then open a new PR to set the version to 1.0.0-rc1

@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 10, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 10, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 10, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 10, 2021
@parthea parthea added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Jun 10, 2021
@parthea parthea changed the title feat!: add v3 feat: add v3 Jun 10, 2021
@parthea parthea added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Jun 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 72f69f0 into master Jun 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the add-v3 branch June 10, 2021 23:26
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 10, 2021
@parthea parthea mentioned this pull request Jun 14, 2021
Closed
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 14, 2021
@release-please
chore: release 1.0.0-rc1 (#65)
748d2a0 
🤖 I have created a release \*beep\* \*boop\*
---
## [1.0.0-rc1](https://www.github.com/googleapis/python-resource-manager/compare/v0.30.3...v1.0.0-rc1) (2021-06-14)


### Features

* add v3 ([#62](https://www.github.com/googleapis/python-resource-manager/issues/62)) ([72f69f0](https://www.github.com/googleapis/python-resource-manager/commit/72f69f0f3a2205ef3bb49ca3e3ae670fd103f6cb))


### Bug Fixes

* remove v1beta1 ([72f69f0](https://www.github.com/googleapis/python-resource-manager/commit/72f69f0f3a2205ef3bb49ca3e3ae670fd103f6cb))
* require google-cloud-core >= 1.3.0 ([#43](https://www.github.com/googleapis/python-resource-manager/issues/43)) ([16df2d0](https://www.github.com/googleapis/python-resource-manager/commit/16df2d064b25ac75234cbbd736b16fba53a51f2d))


### Miscellaneous Chores

* release as 1.0.0-rc1 ([#64](https://www.github.com/googleapis/python-resource-manager/issues/64)) ([cce4608](https://www.github.com/googleapis/python-resource-manager/commit/cce46083be8cd73cbe921ee8ac917806507b6084))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 19, 2021
@release-please
chore: release 1.0.0 (#82)
8825bd8 
Fixes #77

🤖 I have created a release \*beep\* \*boop\*
---
## [1.0.0](https://www.github.com/googleapis/python-resource-manager/compare/v0.30.3...v1.0.0) (2021-07-18)


### Features

* add always_use_jwt_access ([#73](https://www.github.com/googleapis/python-resource-manager/issues/73)) ([9c0bc88](https://www.github.com/googleapis/python-resource-manager/commit/9c0bc888c685f2dbcbc66ca73e7fd4f27d5be47e))
* add v3 ([#62](https://www.github.com/googleapis/python-resource-manager/issues/62)) ([72f69f0](https://www.github.com/googleapis/python-resource-manager/commit/72f69f0f3a2205ef3bb49ca3e3ae670fd103f6cb))


### Bug Fixes

* disable always_use_jwt_access ([#76](https://www.github.com/googleapis/python-resource-manager/issues/76)) ([9f36514](https://www.github.com/googleapis/python-resource-manager/commit/9f365141716b2acc90bb16132dba48b38e470a9b))
* remove v1beta1 ([72f69f0](https://www.github.com/googleapis/python-resource-manager/commit/72f69f0f3a2205ef3bb49ca3e3ae670fd103f6cb))
* require google-cloud-core >= 1.3.0 ([#43](https://www.github.com/googleapis/python-resource-manager/issues/43)) ([16df2d0](https://www.github.com/googleapis/python-resource-manager/commit/16df2d064b25ac75234cbbd736b16fba53a51f2d))


### Documentation

* omit mention of Python 2.7 in 'CONTRIBUTING.rst' ([#1127](https://www.github.com/googleapis/python-resource-manager/issues/1127)) ([#68](https://www.github.com/googleapis/python-resource-manager/issues/68)) ([d6e699e](https://www.github.com/googleapis/python-resource-manager/commit/d6e699eb0492c979871ed69f6badbec8ab3427f4)), closes [#1126](https://www.github.com/googleapis/python-resource-manager/issues/1126)


### Miscellaneous Chores

* release as 1.0.0 ([#78](https://www.github.com/googleapis/python-resource-manager/issues/78)) ([fc852aa](https://www.github.com/googleapis/python-resource-manager/commit/fc852aa0b0e42a37324ca94901c34015e6127df2))
* release as 1.0.0-rc1 ([#64](https://www.github.com/googleapis/python-resource-manager/issues/64)) ([cce4608](https://www.github.com/googleapis/python-resource-manager/commit/cce46083be8cd73cbe921ee8ac917806507b6084))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: cloudresourcemanager Issues related to the googleapis/python-resource-manager API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Resource Manager: update API from v1beta1 to v3

3 participants

@parthea @busunkim96 @yoshi-kokoro