This repository was archived by the owner on Sep 16, 2023. It is now read-only.
fix: change location in IT to be 'global'#103
Merged
athakor merged 1 commit intogoogleapis:masterfrom Dec 11, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
=========================================
Coverage 74.29% 74.29%
Complexity 1338 1338
=========================================
Files 138 138
Lines 10483 10483
Branches 96 96
=========================================
Hits 7788 7788
Misses 2519 2519
Partials 176 176 Continue to review full report at Codecov.
|
Change the location ID in integration test to be "global" instead of "us." "global" is a more standardized usage. "us" is just a legacy usage that we supported.
3da5684 to
2fda57d
Compare
athakor
approved these changes
Dec 11, 2020
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Dec 15, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [0.5.0](https://www.github.com/googleapis/java-dialogflow-cx/compare/v0.4.1...v0.5.0) (2020-12-15) ### Features * allowed custom to specify webhook headers through query parameters ([#109](https://www.github.com/googleapis/java-dialogflow-cx/issues/109)) ([329b306](https://www.github.com/googleapis/java-dialogflow-cx/commit/329b306505d291dc9f7b3e9832adf20d0abc30a8)) ### Bug Fixes * change location in IT to be 'global' ([#103](https://www.github.com/googleapis/java-dialogflow-cx/issues/103)) ([4053872](https://www.github.com/googleapis/java-dialogflow-cx/commit/405387236262b9d04b074304f78f1cc1da4b662b)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.16.1 ([e0830ab](https://www.github.com/googleapis/java-dialogflow-cx/commit/e0830ab54843fce058aa9bdcf0e228e7c5b827fb)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.17.0 ([#114](https://www.github.com/googleapis/java-dialogflow-cx/issues/114)) ([772e3e6](https://www.github.com/googleapis/java-dialogflow-cx/commit/772e3e616d169e7ca496d80a49b46d272169ada8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the location ID in integration test to be "global" instead of "us" because the former is more standardized. "us" is just a legacy usage that we supported.