added cache for table cells#1051
Open
samzhangjy wants to merge 1 commit intopython-openxml:masterfrom
Open
Conversation
Closed
|
Wow, I tested your modification, and it is top speed ! Many thanks for providing the cache update. Hope it will be pushed in the main branch soon. |
|
Very useful bro, how does the magic happen? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I added a cache when accessing table cells using
table._cells, and the performance improvement is pretty big.Before adding cache: 99.94s
Added cache: 1.55s
Hopefully this feature will be merged to the master branch because accessing large tables are just too slow here...
Thanks！