Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): version Android text-align justify #9620

Conversation

@vallemar
Copy link
Contributor

@vallemar vallemar commented Oct 20, 2021

This PR is pointing to the android version> = 25 and is breaking this version since this property came out in the 26 https://developer.android.com/reference/android/text/Layout#JUSTIFICATION_MODE_NONE

This PR solves the version.

@cla-bot cla-bot bot added the cla: yes label Oct 20, 2021
@NathanWalker NathanWalker merged commit 2ad280d into NativeScript:master Oct 20, 2021
2 of 3 checks passed
@vallemar
Copy link
Contributor Author

@vallemar vallemar commented Oct 28, 2021

Hi @NathanWalker, I wonder why this troubleshooting does not come out as an intermediate version just when they are corrected. Surely this error is penalizing many people in version 8.1.4. I know that it can be corrected with @next but, wouldn't it be better to get a version (8.1.5) so as not to interfere with anyone without having to know the @next?

@NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Oct 28, 2021

Yes I agree thanks for ping, we will look at getting 8.1.5 out.

@NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Oct 28, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants