Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove support for end-of-life Python 2.7 #432
Conversation
|
I am strongly opposed to this. There are still many consumers of html5lib who can't or haven't migrated to Python 3. Although PSF is no longer supporting Python 2.7 it's still under support in e.g. RHEL. |
|
No problem. With this change, I'm only trying to help this project and the larger Python community. I figure sooner or later, someone would need to do this maintenance work. If the project policy is to continue supporting Python 2.7, no worries. That said, Python 2.7 user can continue using the last release of html5lib that supported 2.7 which is 1.0.1 as of this writing, released Dec 7, 2017. As users haven't had a new release in over a year, there wouldn't really be any immediate change for them. The setup.py file users |
Python 2.7 has been EOL since 2020-01-01. It is no longer receiving security updates. By removing Python 2 support, can reduce testing resources and simplify the code by removing compatibility shims. Removes dependency on six. Removes test dependency on mock.
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
- Coverage 90.52% 89.69% -0.83%
==========================================
Files 50 49 -1
Lines 6973 6872 -101
Branches 1328 1310 -18
==========================================
- Hits 6312 6164 -148
- Misses 502 545 +43
- Partials 159 163 +4
Continue to review full report at Codecov.
|
|
Note that this implies pip staying on the last Py2-supporting release, which is potentially troublesome given the current last Py2 release doesn't support Py3.future and implies pip vending multiple versions of html5lib. I'd rather stick to the somewhat unwritten policy of supporting at least the same versions that pip supports (and we should document that). Let's move any discussion about the policy to #439, and close this for now. |
Python 2.7 has been EOL since 2020-01-01. It is no longer receiving
security updates.
By removing Python 2 support, can reduce testing resources and simplify
the code by removing compatibility shims.
Removes dependency on six.
Removes test dependency on mock.