Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updon't encode the file in "bpython file.py" #617
Closed
Conversation
|
I think we should first add tests of what we expect. Also, this change breaks the current tests. |
|
Fix in #627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
thomasballinger commentedJun 6, 2016
I'd like to do this to solve #608 but I'm never positive about encoding issues.
In Python 2 if we're reading a file from the command line, it's totally reasonable for us not to add our own encoding line, right? If it needs to be encoded, then there needed to be an encoding line there and if there is then we're munging it.