Skip to content

/ bpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of lines in stacktrace is incorrect for bpython 0.15 is correct #608

Closed
xudaniel11work opened this issue Apr 11, 2016 · 4 comments
Closed

Number of lines in stacktrace is incorrect for bpython 0.15 is correct #608

xudaniel11work opened this issue Apr 11, 2016 · 4 comments

Comments

@xudaniel11work
Copy link

@xudaniel11work xudaniel11work commented Apr 11, 2016

Problem - Given a program with a bug, bpython will not properly locate the line of the bug in the stack-trace (even though it will identify that there is a bug, and the text of the bug). For example, if I have a program called test.py and there is a misspelling bug located on line 10, running bpython test.py will print out a stack-trace and claim that the misspelling bug is located on line 12.

OS - Mac OSX El Capitan
Python Interpreter - Python 2.7.11 (default, Jan 22 2016, 08:29:18)
[GCC 4.2.1 Compatible Apple LLVM 7.0.2 (clang-700.1.81)] on darwin
bPython Version - 0.15

NOTE - This bug does not occur on bPython version 0.14.1!

screenshot 2016-04-11 16 36 33
@thomasballinger
Copy link
Member

@thomasballinger thomasballinger commented Apr 12, 2016

Thanks for reporting this, this is probably to do with 1) adding 2 encoding lines, and 2) not rewriting the stack trace like we do in other places. I'll take a look next week.
@thomasballinger thomasballinger mentioned this issue Jun 6, 2016
Closed
@thomasballinger
Copy link
Member

@thomasballinger thomasballinger commented Jun 6, 2016

I'm going to wait for someone to sanity check this for me, but I think we can just stop adding the two lines we add to the top of this file.
@xudaniel11work
Copy link
Author

@xudaniel11work xudaniel11work commented Jul 10, 2016

Thanks @thomasballinger! Let me know when this is fixed :P
@Trundle
Copy link
Member

@Trundle Trundle commented Oct 10, 2016

This issue has been fixed with the changes made in #627 (df29ae1, to be precise).
@Trundle Trundle closed this Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@Trundle @thomasballinger @xudaniel11work
You can’t perform that action at this time.