Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

docs: adds OR filter sample#1032

Merged
telpirion merged 14 commits intomainfrom
or-filter
Mar 28, 2023
Merged

docs: adds OR filter sample#1032
telpirion merged 14 commits intomainfrom
or-filter

Conversation

@telpirion
Copy link
Copy Markdown
Contributor

No description provided.

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. labels Mar 24, 2023
Comment thread samples/snippets/src/test/java/com/example/datastore/OrFilterQuerySampleIT.java Outdated
@kolea2
Copy link
Copy Markdown
Contributor

kolea2 commented Mar 27, 2023

@jlara310 fyi!

Comment thread samples/snippets/src/main/java/com/example/datastore/filters/OrFilterQuery.java Outdated
@telpirion telpirion marked this pull request as ready for review March 27, 2023 16:42
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Mar 27, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion requested review from jainsahab and kolea2 March 27, 2023 16:44
@gcf-owl-bot gcf-owl-bot Bot requested review from a team March 27, 2023 16:45
Copy link
Copy Markdown
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current changes look good, it would be nice to also have a nested OR example. Will defer to @jlara310 here for requirements

@telpirion
Copy link
Copy Markdown
Contributor Author

@kolea2 I think we should discuss a nested OR query in a follow-up PR. WDYT?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants