Skip to content

docs(samples): modified comments in the samples and minor refactor#990

Merged
lesv merged 4 commits intomainfrom
patch-auth-samples
Sep 13, 2022
Merged

docs(samples): modified comments in the samples and minor refactor#990
lesv merged 4 commits intomainfrom
patch-auth-samples

Conversation

@Sita04
Copy link
Copy Markdown
Contributor

@Sita04 Sita04 commented Aug 29, 2022

Changes:

  1. Modified Auth implicit sample to use GCS instead of GCE.
  2. Modified comments
  3. Minor variable value refactoring

@Sita04 Sita04 requested a review from a team August 29, 2022 08:20
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. samples Issues that are directly related to samples. labels Aug 29, 2022
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2022
Comment thread samples/snippets/src/main/java/AuthenticateImplicitWithAdc.java Outdated
Comment thread samples/snippets/src/main/java/VerifyGoogleIdToken.java Outdated
@Sita04 Sita04 requested a review from piaxc August 30, 2022 07:56
Copy link
Copy Markdown
Contributor

@piaxc piaxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sita!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants