Fix relative redirects regression. Closes #13607#13616
Merged
ematipico merged 3 commits intowithastro:mainfrom Apr 16, 2025
Merged
Fix relative redirects regression. Closes #13607#13616ematipico merged 3 commits intowithastro:mainfrom
ematipico merged 3 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: c096879 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3fbad8f to
92a43e2
Compare
1 task
CodSpeed Performance ReportMerging #13616 will not alter performanceComparing Summary
|
ematipico
requested changes
Apr 15, 2025
Contributor
Author
|
Oh 🤦 forgive me, shouldn't have done it after a long day at work 😄 Funnily enough it worked and test passed 😂 I'll push a fix later today |
1 task
92a43e2 to
c85a46e
Compare
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Contributor
Author
|
@ematipico ready for you again |
ematipico
approved these changes
Apr 16, 2025
Merged
openscript
pushed a commit
to openscript/astro
that referenced
this pull request
Sep 12, 2025
…13616) Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
As per #13607, redirects had a regression with relative redirects introduced in #12979. This PR fixes it.
Fixes #13607
Testing
Docs
/cc @withastro/maintainers-docs for feedback! This was never documented but always worked since early versions of Astro so as mentioned by @ematipico on #13607 we should probaly update the docs. Happy to have a stab at it if you want too.